[webkit-changes] [WebKit/WebKit] 197488: Replace printingSendOptions with separate message ...
EWS
noreply at github.com
Wed Nov 9 10:40:05 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1974887d7d1de2a00fd72488f41128bd2176cccf
https://github.com/WebKit/WebKit/commit/1974887d7d1de2a00fd72488f41128bd2176cccf
Author: Alex Christensen <achristensen at webkit.org>
Date: 2022-11-09 (Wed, 09 Nov 2022)
Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
Log Message:
-----------
Replace printingSendOptions with separate message names
https://bugs.webkit.org/show_bug.cgi?id=247680
Reviewed by Tim Horton.
This will allow us to remove the OptionSet<SendOption> parameter and derive it from the message name,
then move the source of that parameter to the *.messages.in file, then add receiver-side checks from
generated code.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::preferencesDidChange):
(WebKit::WebPageProxy::beginPrinting):
(WebKit::WebPageProxy::endPrinting):
(WebKit::WebPageProxy::computePagesForPrinting):
(WebKit::WebPageProxy::drawRectToImage):
(WebKit::WebPageProxy::drawPagesToPDF):
(WebKit::WebPageProxy::drawPagesForPrinting):
(WebKit::printingSendOptions): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::beginPrintingDuringDOMPrintOperation):
(WebKit::WebPage::endPrintingDuringDOMPrintOperation):
(WebKit::WebPage::computePagesForPrintingDuringDOMPrintOperation):
(WebKit::WebPage::drawRectToImageDuringDOMPrintOperation):
(WebKit::WebPage::drawPagesToPDFDuringDOMPrintOperation):
(WebKit::WebPage::drawPagesForPrintingDuringDOMPrintOperation):
(WebKit::WebPage::preferencesDidChangeDuringDOMPrintOperation):
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
Canonical link: https://commits.webkit.org/256490@main
More information about the webkit-changes
mailing list