[webkit-changes] [WebKit/WebKit] 80917d: Add context menu items to play all or pause all an...
Tyler Wilcock
noreply at github.com
Sat Nov 5 11:59:31 PDT 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 80917d380ef11465edfa61e2dd26dd4c9a05c5ba
https://github.com/WebKit/WebKit/commit/80917d380ef11465edfa61e2dd26dd4c9a05c5ba
Author: Tyler Wilcock <tyler_w at apple.com>
Date: 2022-11-05 (Sat, 05 Nov 2022)
Changed paths:
A LayoutTests/fast/images/mac/play-all-pause-all-animations-context-menu-items-expected.txt
A LayoutTests/fast/images/mac/play-all-pause-all-animations-context-menu-items.html
M Source/WebCore/en.lproj/Localizable.strings
M Source/WebCore/html/HTMLImageElement.cpp
M Source/WebCore/html/HTMLImageElement.h
M Source/WebCore/page/ContextMenuController.cpp
M Source/WebCore/platform/ContextMenuItem.cpp
M Source/WebCore/platform/ContextMenuItem.h
M Source/WebCore/platform/LocalizedStrings.cpp
M Source/WebCore/platform/LocalizedStrings.h
M Source/WebKit/Shared/API/c/WKContextMenuItem.cpp
M Source/WebKit/Shared/API/c/WKContextMenuItemTypes.h
M Source/WebKit/Shared/API/c/WKSharedAPICast.h
M Source/WebKit/UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm
M Source/WebKit/UIProcess/API/Cocoa/WKMenuItemIdentifiersPrivate.h
M Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm
M Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm
M Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
M Source/WebKitLegacy/mac/WebView/WebUIDelegatePrivate.h
Log Message:
-----------
Add context menu items to play all or pause all animations on the page
https://bugs.webkit.org/show_bug.cgi?id=247377
rdar://101878359
Reviewed by Chris Fleizach.
Expose context menu items to play all or pause all animations on the
page. This is a continuation of:
https://bugs.webkit.org/show_bug.cgi?id=244128 (Add experimental feature to control image animation play/pause state)
https://bugs.webkit.org/show_bug.cgi?id=245399 (SVG animations should respect Page::imageAnimationEnabled)
* LayoutTests/fast/images/mac/play-all-pause-all-animations-context-menu-items-expected.txt: Added.
* LayoutTests/fast/images/mac/play-all-pause-all-animations-context-menu-items.html: Added.
* Source/WebCore/en.lproj/Localizable.strings:
* Source/WebCore/html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::resetAllowsAnimation):
Delete this function as it's not used anywhere.
* Source/WebCore/html/HTMLImageElement.h:
* Source/WebCore/page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded const):
* Source/WebCore/platform/ContextMenuItem.cpp:
(WebCore::isValidContextMenuAction):
* Source/WebCore/platform/ContextMenuItem.h:
* Source/WebCore/platform/LocalizedStrings.cpp:
(WebCore::contextMenuItemTagPlayAllAnimations):
(WebCore::contextMenuItemTagPauseAllAnimations):
* Source/WebCore/platform/LocalizedStrings.h:
* Source/WebKit/Shared/API/c/WKContextMenuItem.cpp:
* Source/WebKit/Shared/API/c/WKContextMenuItemTypes.h:
* Source/WebKit/Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
(WebKit::toImpl):
* Source/WebKit/UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm:
* Source/WebKit/UIProcess/API/Cocoa/WKMenuItemIdentifiersPrivate.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm:
* Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::menuItemIdentifier):
* Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:
(toTag):
* Source/WebKitLegacy/mac/WebView/WebUIDelegatePrivate.h:
Canonical link: https://commits.webkit.org/256360@main
More information about the webkit-changes
mailing list