[webkit-changes] [WebKit/WebKit] 831c68: WebKit should not depend on CA's implicit auto-upg...

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 831c68acbcc6c5c7992a250059b330f261bcf2a0
      https://github.com/WebKit/WebKit/commit/831c68acbcc6c5c7992a250059b330f261bcf2a0
  Author: Tim Horton <timothy_horton at apple.com>
  Date:   2022-11-05 (Sat, 05 Nov 2022)

  Changed paths:
    M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.h
    M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm
    M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm

  Log Message:
  -----------
  WebKit should not depend on CA's implicit auto-upgrade to extendedSRGB
https://bugs.webkit.org/show_bug.cgi?id=247218
rdar://101695786

Reviewed by Said Abou-Hallawa and Sam Weinig.

* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.h:
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::colorSpace const):
(WebKit::RemoteLayerBackingStore::ensureFrontBuffer):
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm:
(WebKit::RemoteLayerBackingStoreCollection::allocateBufferForBackingStore):
We currently depend on a special case in CA to upgrade RemoteLayerBackingStore's
backing store to extended SRGB in the case where we are using half-float pixel
formats. We ask for standard SRGB, but they notice the floating point format
and upgrade us.

Instead of doing this, we should explicitly say that we want extended SRGB
when using such backing store.

Canonical link: https://commits.webkit.org/256361@main