[webkit-changes] [WebKit/WebKit] d26eba: Element::attachDeclarativeShadow should set IsAvai...

Ryosuke Niwa noreply at github.com
Wed Dec 21 19:21:05 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d26eba5eb7ab2fc3f968705e31b7d965d25bafd8
      https://github.com/WebKit/WebKit/commit/d26eba5eb7ab2fc3f968705e31b7d965d25bafd8
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2022-12-21 (Wed, 21 Dec 2022)

  Changed paths:
    M LayoutTests/fast/shadow-dom/element-internals-exposes-declarative-shadow-root-expected.txt
    M LayoutTests/fast/shadow-dom/element-internals-exposes-declarative-shadow-root.html
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/ElementInternals.cpp
    M Source/WebCore/dom/ShadowRoot.h

  Log Message:
  -----------
  Element::attachDeclarativeShadow should set IsAvailableToElementInternals
https://bugs.webkit.org/show_bug.cgi?id=249668

Reviewed by Chris Dumez.

Make Element::attachDeclarativeShadow set ShadowRoot::m_isAttachDeclarativeShadow flag
instead of checking isDeclarativeShadowRoot in ElementInternals::shadowRoot.

Also update the assertions in the test to match the latest spec PR.

* LayoutTests/fast/shadow-dom/element-internals-exposes-declarative-shadow-root-expected.txt:
* LayoutTests/fast/shadow-dom/element-internals-exposes-declarative-shadow-root.html:
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::attachDeclarativeShadow)
* Source/WebCore/dom/ElementInternals.cpp:
(WebCore::ElementInternals::shadowRoot const):
* Source/WebCore/dom/ShadowRoot.h:

Canonical link: https://commits.webkit.org/258231@main




More information about the webkit-changes mailing list