[webkit-changes] [WebKit/WebKit] 3edf24: Give up on stretching columns if they have already...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3edf242b588be169967f082cdef66d7e21878448
      https://github.com/WebKit/WebKit/commit/3edf242b588be169967f082cdef66d7e21878448
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2022-12-21 (Wed, 21 Dec 2022)

  Changed paths:
    A LayoutTests/fast/multicol/unbreakable-content-taller-than-height-crash-expected.txt
    A LayoutTests/fast/multicol/unbreakable-content-taller-than-height-crash.html
    M Source/WebCore/rendering/RenderMultiColumnSet.cpp

  Log Message:
  -----------
  Give up on stretching columns if they have already reached max height

Give up on stretching columns if they have already reached max height
https://bugs.webkit.org/show_bug.cgi?id=249705

Reviewed by Alan Baradlay.

Merge - https://src.chromium.org/viewvc/blink?view=revision&revision=192636

This doesn't change any behavior (column heights were already clamped against
max height), but it avoids an assertion failure that would occur if no space
shortage is recorded during a render pass. Unbreakable content (lines) that's
taller than the column (max) height don't record space shortage, as columns
cannot be stretched beyond the (max) height anyway.

* Source/WebCore/rendering/RenderMultiColumnSet.cpp:
(RenderMultiColumnSet::calculateBalancedHeight): Add if condition to restrict column height
* LayoutTests/fast/multicol/unbreakable-content-taller-than-height-crash.html: Add Test Case
* LayoutTests/fast/multicol/unbreakable-content-taller-than-height-crash-expected.txt: Add Test Case Expectation

Canonical link: https://commits.webkit.org/258230@main