[webkit-changes] [WebKit/WebKit] 5ec2d0: IDL and Sandbox preprocessor invocation doesn't ha...
Tim Horton
noreply at github.com
Thu Dec 15 07:42:53 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5ec2d0dd0c8f83a720b8d057bb60c6953eed85e8
https://github.com/WebKit/WebKit/commit/5ec2d0dd0c8f83a720b8d057bb60c6953eed85e8
Author: Tim Horton <thorton at apple.com>
Date: 2022-12-15 (Thu, 15 Dec 2022)
Changed paths:
M Source/JavaScriptCore/DerivedSources.make
M Source/WebCore/DerivedSources.make
M Source/WebKit/DerivedSources.make
Log Message:
-----------
IDL and Sandbox preprocessor invocation doesn't have defines from GCC_PREPROCESSOR_DEFINITIONS
https://bugs.webkit.org/show_bug.cgi?id=249363
rdar://103381924
Reviewed by Alexey Proskuryakov.
* Source/JavaScriptCore/DerivedSources.make:
* Source/WebCore/DerivedSources.make:
* Source/WebKit/DerivedSources.make:
Include defines from GCC_PREPROCESSOR_DEFINITIONS when calling out
to the preprocessor for IDL and Sandbox files. This can in some cases
cause mismatches between the features enabled in C++ code and in IDLs
or sandbox profiles.
Also set RELEASE_WITHOUT_OPTIMIZATIONS; otherwise in release builds,
GCC_PREPROCESSOR_DEFINITIONS gets us -NDEBUG, but not -O3, and Platform.h
complains about the unexpected mismatch.
Canonical link: https://commits.webkit.org/257915@main
More information about the webkit-changes
mailing list