[webkit-changes] [WebKit/WebKit] cc5718: Warn web developers if a WebCodecsVideoFrame is de...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cc57182c3c1340406032846854f75b175f46f6ed
      https://github.com/WebKit/WebKit/commit/cc57182c3c1340406032846854f75b175f46f6ed
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2022-12-15 (Thu, 15 Dec 2022)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/http/wpt/webcodecs/videoFrame-colorSpace.html
    M LayoutTests/http/wpt/webcodecs/webcodecs-gc.html
    A LayoutTests/http/wpt/webcodecs/webcodecs-message-gc-expected.txt
    A LayoutTests/http/wpt/webcodecs/webcodecs-message-gc.html
    M LayoutTests/imported/w3c/web-platform-tests/webcodecs/reconfiguring-encoder.https.any.js
    M LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder.https.any.js
    M Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.cpp
    M Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.cpp
    M Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.h
    M Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.idl
    M Source/WebCore/bindings/js/SerializedScriptValue.cpp

  Log Message:
  -----------
  Warn web developers if a WebCodecsVideoFrame is destroyed without close being called
https://bugs.webkit.org/show_bug.cgi?id=247728
rdar://problem/102188812

Reviewed by Eric Carlson.

Make WebCodecsVideoFrame be a ContextDestructionObserver so that we can post a task to add a warning message from WebCodecsVideoFrame destructor if the WebCodecsVideoFrame is not detached.

* LayoutTests/TestExpectations:
* LayoutTests/http/wpt/webcodecs/webcodecs-gc.html:
* LayoutTests/http/wpt/webcodecs/webcodecs-message-gc-expected.txt: Added.
* LayoutTests/http/wpt/webcodecs/webcodecs-message-gc.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/reconfiguring-encoder.https.any.js:
(promise_test.async t):
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder.https.any.js:
(promise_test.async t):
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-createImageBitmap.any.js:
(testImageBitmapToAndFromVideoFrame):
(promise_test):
* Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.cpp:
(WebCore::WebCodecsVideoDecoder::configure):
* Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.cpp:
(WebCore::WebCodecsVideoFrame::WebCodecsVideoFrame):
(WebCore::WebCodecsVideoFrame::~WebCodecsVideoFrame):
(WebCore::WebCodecsVideoFrame::create):
(WebCore::WebCodecsVideoFrame::initializeFrameFromOtherFrame):
(WebCore::WebCodecsVideoFrame::initializeFrameWithResourceAndSize):
(WebCore::WebCodecsVideoFrame::clone):
* Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.h:
(WebCore::WebCodecsVideoFrame::create):
* Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.idl:
* Source/WebCore/bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::readWebCodecsVideoFrame):

Canonical link: https://commits.webkit.org/257914@main