[webkit-changes] [WebKit/WebKit] c893ed: Creating a _WKWebExtension with an invalid path sh...

Timothy Hatcher noreply at github.com
Thu Dec 8 13:07:10 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c893edaa156c8a67f63eee27e62b3d8e283fb7a8
      https://github.com/WebKit/WebKit/commit/c893edaa156c8a67f63eee27e62b3d8e283fb7a8
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2022-12-08 (Thu, 08 Dec 2022)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtension.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtension.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
    M Source/WebKit/UIProcess/Extensions/WebExtension.h
    M Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm

  Log Message:
  -----------
  Creating a _WKWebExtension with an invalid path should return nil.
https://bugs.webkit.org/show_bug.cgi?id=248960

Reviewed by Brian Weinstein.

* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtension.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtension.mm:
(+[_WKWebExtension extensionWithAppExtensionBundle:]): Added.
(+[_WKWebExtension extensionWithResourceBaseURL:]): Added.
(-[_WKWebExtension initWithAppExtensionBundle:error:]): Added error param.
(-[_WKWebExtension initWithResourceBaseURL:error:]): Added error param.
(-[_WKWebExtension _initWithManifestDictionary:]): Added assert.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::WebExtension): Added error param.
* Source/WebKit/UIProcess/Extensions/WebExtension.h:
* Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm:
(TestWebKitAPI::Util::loadAndRunExtension): Use initWithResourceBaseURL:error:.

Canonical link: https://commits.webkit.org/257584@main




More information about the webkit-changes mailing list