[webkit-changes] [WebKit/WebKit] ca905b: [iOS] Add release logging for text interaction ass...

Aditya Keerthi noreply at github.com
Thu Dec 8 12:58:30 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ca905b9282f2eef05324e19e42a94c92e35bc1f7
      https://github.com/WebKit/WebKit/commit/ca905b9282f2eef05324e19e42a94c92e35bc1f7
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2022-12-08 (Thu, 08 Dec 2022)

  Changed paths:
    M Source/WebKit/Platform/Logging.h
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  -----------
  [iOS] Add release logging for text interaction assistant-driven selection changes
https://bugs.webkit.org/show_bug.cgi?id=248955
rdar://103120563

Reviewed by Wenson Hsieh.

Add logging to diagnose a rarely reproducing issue where all taps over text extend the selection.

* Source/WebKit/Platform/Logging.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(operator<<):
(-[WKContentView changeSelectionWithGestureAt:withGesture:withState:withFlags:]):
(-[WKContentView changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:withFlags:]):
(-[WKContentView changeSelectionWithTouchesFrom:to:withGesture:withState:]):
(logTextInteractionAssistantSelectionChange):
(-[WKContentView _selectPositionAtPoint:stayingWithinFocusedElement:completionHandler:]):
(-[WKContentView selectPositionAtBoundary:inDirection:fromPoint:completionHandler:]):
(-[WKContentView moveSelectionAtBoundary:inDirection:completionHandler:]):
(-[WKContentView selectTextWithGranularity:atPoint:completionHandler:]):
(-[WKContentView beginSelectionInDirection:completionHandler:]):
(-[WKContentView updateSelectionWithExtentPoint:completionHandler:]):
(-[WKContentView updateSelectionWithExtentPoint:withBoundary:completionHandler:]):
(-[WKContentView selectPositionAtPoint:withContextRequest:completionHandler:]):

Canonical link: https://commits.webkit.org/257583@main




More information about the webkit-changes mailing list