[webkit-changes] [WebKit/WebKit] 7d03a4: Rename request initiator and initiatorName to init...

Mon Dec 5 09:35:48 PST 2022

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7d03a4356c054b53d53b2572a3ba57ea1a8df076
      https://github.com/WebKit/WebKit/commit/7d03a4356c054b53d53b2572a3ba57ea1a8df076
  Author: Matthew Finkel <sysrqb at apple.com>
  Date:   2022-12-05 (Mon, 05 Dec 2022)

  Changed paths:
    M Source/WebCore/Modules/cache/DOMCache.cpp
    M Source/WebCore/Modules/fetch/FetchLoader.cpp
    M Source/WebCore/Modules/fetch/WindowOrWorkerGlobalScopeFetch.cpp
    M Source/WebCore/Modules/mediasession/MediaMetadata.cpp
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/bindings/js/CachedScriptFetcher.cpp
    M Source/WebCore/bindings/js/CachedScriptFetcher.h
    M Source/WebCore/css/CSSFontFaceSrcValue.cpp
    M Source/WebCore/css/CSSImageValue.cpp
    M Source/WebCore/css/CSSImageValue.h
    M Source/WebCore/css/StyleRuleImport.cpp
    M Source/WebCore/dom/DocumentFontLoader.cpp
    M Source/WebCore/dom/InlineClassicScript.cpp
    M Source/WebCore/dom/InlineClassicScript.h
    M Source/WebCore/dom/LoadableClassicScript.cpp
    M Source/WebCore/dom/LoadableClassicScript.h
    M Source/WebCore/dom/LoadableImportMap.cpp
    M Source/WebCore/dom/LoadableImportMap.h
    M Source/WebCore/dom/LoadableModuleScript.cpp
    M Source/WebCore/dom/LoadableModuleScript.h
    M Source/WebCore/dom/LoadableScript.h
    M Source/WebCore/dom/ScriptElementCachedScriptFetcher.h
    M Source/WebCore/html/parser/HTMLResourcePreloader.cpp
    M Source/WebCore/html/parser/HTMLResourcePreloader.h
    M Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp
    M Source/WebCore/loader/ApplicationManifestLoader.cpp
    M Source/WebCore/loader/CrossOriginPreflightChecker.cpp
    M Source/WebCore/loader/DocumentThreadableLoader.cpp
    M Source/WebCore/loader/LinkLoader.cpp
    M Source/WebCore/loader/ResourceTiming.cpp
    M Source/WebCore/loader/ResourceTiming.h
    M Source/WebCore/loader/ResourceTimingInformation.cpp
    M Source/WebCore/loader/ResourceTimingInformation.h
    M Source/WebCore/loader/SubresourceLoader.cpp
    M Source/WebCore/loader/ThreadableLoader.cpp
    M Source/WebCore/loader/ThreadableLoader.h
    M Source/WebCore/loader/WorkerThreadableLoader.cpp
    M Source/WebCore/loader/cache/CachedResource.cpp
    M Source/WebCore/loader/cache/CachedResource.h
    M Source/WebCore/loader/cache/CachedResourceLoader.cpp
    M Source/WebCore/loader/cache/CachedResourceRequest.cpp
    M Source/WebCore/loader/cache/CachedResourceRequest.h
    A Source/WebCore/loader/cache/CachedResourceRequestInitiatorTypes.cpp
    A Source/WebCore/loader/cache/CachedResourceRequestInitiatorTypes.h
    R Source/WebCore/loader/cache/CachedResourceRequestInitiators.cpp
    R Source/WebCore/loader/cache/CachedResourceRequestInitiators.h
    M Source/WebCore/loader/cache/CachedSVGDocumentReference.cpp
    M Source/WebCore/loader/icon/IconLoader.cpp
    M Source/WebCore/page/EventSource.cpp
    M Source/WebCore/page/PerformanceResourceTiming.h
    M Source/WebCore/platform/ThreadGlobalData.cpp
    M Source/WebCore/platform/ThreadGlobalData.h
    M Source/WebCore/workers/service/FetchEvent.cpp
    M Source/WebCore/xml/XMLHttpRequest.cpp

  Log Message:
  -----------
  Rename request initiator and initiatorName to initiatorType
https://bugs.webkit.org/show_bug.cgi?id=248566
rdar://problem/102832673

Reviewed by Darin Adler.

Resource requests have an "initiator" which is a string that represents "what
triggered this request". That string may be an element type or a script method
(e.g., "fetch"). Internally, "initiator" and "initiatorName" were used
interchangably, and the ResourceTiming API exposes this information as
"initiatorType". This change aligns the internal naming with the spec and
renames uses of "initiator" and "initiatorName" to "initiatorType".

* Source/WebCore/Modules/cache/DOMCache.cpp:
(WebCore::DOMCache::addAll):
* Source/WebCore/Modules/fetch/FetchLoader.cpp:
* Source/WebCore/Modules/fetch/WindowOrWorkerGlobalScopeFetch.cpp:
(WebCore::doFetch):
* Source/WebCore/Modules/mediasession/MediaMetadata.cpp:
(WebCore::ArtworkImageLoader::requestImageResource):
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/bindings/js/CachedScriptFetcher.cpp:
(WebCore::CachedScriptFetcher::requestScriptWithCache const):
* Source/WebCore/bindings/js/CachedScriptFetcher.h:
(WebCore::CachedScriptFetcher::CachedScriptFetcher):
* Source/WebCore/css/CSSFontFaceSrcValue.cpp:
* Source/WebCore/css/CSSImageValue.cpp:
(WebCore::CSSImageValue::CSSImageValue):
(WebCore::CSSImageValue::create):
(WebCore::CSSImageValue::createStyleImage const):
(WebCore::CSSImageValue::loadImage):
* Source/WebCore/css/CSSImageValue.h:
* Source/WebCore/css/StyleRuleImport.cpp:
(WebCore::StyleRuleImport::requestStyleSheet):
* Source/WebCore/dom/DocumentFontLoader.cpp:
(WebCore::DocumentFontLoader::cachedFont):
* Source/WebCore/dom/InlineClassicScript.cpp:
(WebCore::InlineClassicScript::InlineClassicScript):
* Source/WebCore/dom/InlineClassicScript.h:
* Source/WebCore/dom/LoadableClassicScript.cpp:
(WebCore::LoadableNonModuleScriptBase::LoadableNonModuleScriptBase):
(WebCore::LoadableClassicScript::create):
(WebCore::LoadableClassicScript::LoadableClassicScript):
* Source/WebCore/dom/LoadableClassicScript.h:
* Source/WebCore/dom/LoadableImportMap.cpp:
(WebCore::LoadableImportMap::create):
(WebCore::LoadableImportMap::LoadableImportMap):
* Source/WebCore/dom/LoadableImportMap.h:
* Source/WebCore/dom/LoadableModuleScript.cpp:
(WebCore::LoadableModuleScript::create):
(WebCore::LoadableModuleScript::LoadableModuleScript):
* Source/WebCore/dom/LoadableModuleScript.h:
* Source/WebCore/dom/LoadableScript.h:
(WebCore::LoadableScript::LoadableScript):
* Source/WebCore/dom/ScriptElementCachedScriptFetcher.h:
(WebCore::ScriptElementCachedScriptFetcher::ScriptElementCachedScriptFetcher):
* Source/WebCore/html/parser/HTMLResourcePreloader.cpp:
(WebCore::PreloadRequest::resourceRequest):
* Source/WebCore/html/parser/HTMLResourcePreloader.h:
(WebCore::PreloadRequest::PreloadRequest):
* Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::didReceiveThreadableLoaderResponse):
* Source/WebCore/loader/ApplicationManifestLoader.cpp:
* Source/WebCore/loader/CrossOriginPreflightChecker.cpp:
(WebCore::CrossOriginPreflightChecker::startPreflight):
* Source/WebCore/loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::redirectReceived):
(WebCore::DocumentThreadableLoader::didFail):
(WebCore::DocumentThreadableLoader::preflightFailure):
(WebCore::DocumentThreadableLoader::loadRequest):
(WebCore::DocumentThreadableLoader::logErrorAndFail):
* Source/WebCore/loader/LinkLoader.cpp:
(WebCore::LinkLoader::preloadIfNeeded):
* Source/WebCore/loader/ResourceTiming.cpp:
(WebCore::ResourceTiming::ResourceTiming):
(WebCore::ResourceTiming::isolatedCopy const):
(WebCore::ResourceTiming::isolatedCopy):
* Source/WebCore/loader/ResourceTiming.h:
(WebCore::ResourceTiming::initiatorType const):
(WebCore::ResourceTiming::overrideInitiatorType):
(WebCore::ResourceTiming::ResourceTiming):
(WebCore::ResourceTiming::initiator const): Deleted.
(WebCore::ResourceTiming::overrideInitiatorName): Deleted.
* Source/WebCore/loader/ResourceTimingInformation.cpp:
(WebCore::ResourceTimingInformation::addResourceTiming):
(WebCore::ResourceTimingInformation::storeResourceTimingInitiatorInformation):
* Source/WebCore/loader/ResourceTimingInformation.h:
* Source/WebCore/loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::reportResourceTiming):
* Source/WebCore/loader/ThreadableLoader.cpp:
(WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions):
(WebCore::ThreadableLoaderOptions::isolatedCopy const):
(WebCore::ThreadableLoader::logError):
* Source/WebCore/loader/ThreadableLoader.h:
* Source/WebCore/loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishTiming):
* Source/WebCore/loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
* Source/WebCore/loader/cache/CachedResource.h:
(WebCore::CachedResource::initiatorType const):
(WebCore::CachedResource::initiatorName const): Deleted.
* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
* Source/WebCore/loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::setInitiator):
(WebCore::CachedResourceRequest::setInitiatorType):
(WebCore::CachedResourceRequest::initiatorType const):
(WebCore::CachedResourceRequest::initiatorName const): Deleted.
* Source/WebCore/loader/cache/CachedResourceRequest.h:
* Source/WebCore/loader/cache/CachedResourceRequestInitiatorTypes.cpp: Renamed from Source/WebCore/loader/cache/CachedResourceRequestInitiators.cpp.
(WebCore::CachedResourceRequestInitiatorTypes::CachedResourceRequestInitiatorTypes):
* Source/WebCore/loader/cache/CachedResourceRequestInitiatorTypes.h: Renamed from Source/WebCore/loader/cache/CachedResourceRequestInitiators.h.
(WebCore::cachedResourceRequestInitiatorTypes):
* Source/WebCore/loader/cache/CachedSVGDocumentReference.cpp:
(WebCore::CachedSVGDocumentReference::load):
* Source/WebCore/loader/icon/IconLoader.cpp:
(WebCore::IconLoader::startLoading):
* Source/WebCore/page/EventSource.cpp:
(WebCore::EventSource::connect):
* Source/WebCore/page/PerformanceResourceTiming.h:
(WebCore::PerformanceResourceTiming::initiatorType const):
* Source/WebCore/platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::initializeCachedResourceRequestInitiatorTypes):
(WebCore::ThreadGlobalData::initializeCachedResourceRequestInitiators): Deleted.
* Source/WebCore/platform/ThreadGlobalData.h:
(WebCore::ThreadGlobalData::cachedResourceRequestInitiatorTypes):
(WebCore::ThreadGlobalData::cachedResourceRequestInitiators): Deleted.
* Source/WebCore/workers/service/FetchEvent.cpp:
(WebCore::FetchEvent::navigationPreloadIsReady):
* Source/WebCore/xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):

Canonical link: https://commits.webkit.org/257374@main