[webkit-changes] [WebKit/WebKit] 171728: EWS pulls the wrong revision when checking out the...

Jonathan Bedard noreply at github.com
Mon Dec 5 08:23:41 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 171728f99da730aa5134f37439b5de387ec8dd19
      https://github.com/WebKit/WebKit/commit/171728f99da730aa5134f37439b5de387ec8dd19
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2022-12-05 (Mon, 05 Dec 2022)

  Changed paths:
    M Tools/CISupport/ews-build/steps.py
    M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  -----------
  EWS pulls the wrong revision when checking out the tree for testing for PRs
https://bugs.webkit.org/show_bug.cgi?id=248725
rdar://102964437

Reviewed by Alexey Proskuryakov and Aakash Jain.

After https://commits.webkit.org/257193@main, PRs are no longer testing against
the ews revision and are instead testing against tip-of-tree, which is incorrect.

* Tools/CISupport/ews-build/steps.py:
(CheckOutSpecificRevision.doStepIf): Do step for PRs as well as patches.
* Tools/CISupport/ews-build/steps_unittest.py:
(TestCheckOutSpecificRevision.test_skip_pr): Deleted.

Canonical link: https://commits.webkit.org/257373@main




More information about the webkit-changes mailing list