No subject

9967">r149967</a> by &lt;esprehn at chromium.org&gt;
&lt;http://src.chromium.org/viewvc/blink?view=3Drevision&amp;revision=3D1=
49967&gt;

Several methods on Document are virtual but don't override a super class =
method
and don't need to be virtual. This patch devirtualizes:

    - createElementNS()
    - finishedParsing()
    - suspendScriptedAnimationControllerCallbacks()
    - resumeScriptedAnimationControllerCallbacks()

It also removes the suspend and resume callbacks from ScriptExecutionCont=
ext
since they didn't need to be there.

* dom/Document.h:
* dom/ScriptExecutionContext.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href=3D"#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeL=
og</a></li>
<li><a href=3D"#trunkSourceWebCoredomDocumenth">trunk/Source/WebCore/dom/=
Document.h</a></li>
<li><a href=3D"#trunkSourceWebCoredomScriptExecutionContexth">trunk/Sourc=
e/WebCore/dom/ScriptExecutionContext.h</a></li>
</ul>

</div>
<div id=3D"patch">
<h3>Diff</h3>
<a id=3D"trunkSourceWebCoreChangeLog"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (1499=
58 =3D> 149959)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/ChangeLog	2013-05-12 14:11:=
47 UTC (rev 149958)
+++ trunk/Source/WebCore/ChangeLog	2013-05-12 14:23:09 UTC (rev 149959)
</span><span class=3D"lines">@@ -1,5 +1,26 @@
</span><span class=3D"cx"> 2013-05-12  Andreas Kling  &lt;akling at apple.co=
m&gt;
</span><span class=3D"cx">=20
</span><ins>+        Devirtualize some things on Document.
+
+        From Blink r149967 by &lt;esprehn at chromium.org&gt;
+        &lt;http://src.chromium.org/viewvc/blink?view=3Drevision&amp;rev=
ision=3D149967&gt;
+
+        Several methods on Document are virtual but don't override a sup=
er class method
+        and don't need to be virtual. This patch devirtualizes:
+
+            - createElementNS()
+            - finishedParsing()
+            - suspendScriptedAnimationControllerCallbacks()
+            - resumeScriptedAnimationControllerCallbacks()
+
+        It also removes the suspend and resume callbacks from ScriptExec=
utionContext
+        since they didn't need to be there.
+
+        * dom/Document.h:
+        * dom/ScriptExecutionContext.h:
+
+2013-05-12  Andreas Kling  &lt;akling at apple.com&gt;
+
</ins><span class=3D"cx">         Remove redundant call to removeAllEvent=
Listeners() in Document::open().
</span><span class=3D"cx">=20
</span><span class=3D"cx">         From Blink r150175 by &lt;dcheng at chrom=
ium.org&gt;
</span></span></pre></div>
<a id=3D"trunkSourceWebCoredomDocumenth"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.h =
(149958 =3D> 149959)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/dom/Document.h	2013-05-12 1=
4:11:47 UTC (rev 149958)
+++ trunk/Source/WebCore/dom/Document.h	2013-05-12 14:23:09 UTC (rev 1499=
59)
</span><span class=3D"lines">@@ -358,7 +358,7 @@
</span><span class=3D"cx">     PassRefPtr&lt;EntityReference&gt; createEn=
tityReference(const String&amp; name, ExceptionCode&amp;);
</span><span class=3D"cx">     PassRefPtr&lt;Node&gt; importNode(Node* im=
portedNode, ExceptionCode&amp; ec) { return importNode(importedNode, true=
, ec); }
</span><span class=3D"cx">     PassRefPtr&lt;Node&gt; importNode(Node* im=
portedNode, bool deep, ExceptionCode&amp;);
</span><del>-    virtual PassRefPtr&lt;Element&gt; createElementNS(const =
String&amp; namespaceURI, const String&amp; qualifiedName, ExceptionCode&=
amp;);
</del><ins>+    PassRefPtr&lt;Element&gt; createElementNS(const String&am=
p; namespaceURI, const String&amp; qualifiedName, ExceptionCode&amp;);
</ins><span class=3D"cx">     PassRefPtr&lt;Element&gt; createElement(con=
st QualifiedName&amp;, bool createdByParser);
</span><span class=3D"cx">=20
</span><span class=3D"cx">     bool cssStickyPositionEnabled() const;
</span><span class=3D"lines">@@ -945,12 +945,12 @@
</span><span class=3D"cx">=20
</span><span class=3D"cx">     virtual void postTask(PassOwnPtr&lt;Task&g=
t;); // Executes the task on context's thread asynchronously.
</span><span class=3D"cx">=20
</span><del>-    virtual void suspendScriptedAnimationControllerCallbacks=
();
-    virtual void resumeScriptedAnimationControllerCallbacks();
</del><ins>+    void suspendScriptedAnimationControllerCallbacks();
+    void resumeScriptedAnimationControllerCallbacks();
</ins><span class=3D"cx">    =20
</span><span class=3D"cx">     void windowScreenDidChange(PlatformDisplay=
ID);
</span><span class=3D"cx">=20
</span><del>-    virtual void finishedParsing();
</del><ins>+    void finishedParsing();
</ins><span class=3D"cx">=20
</span><span class=3D"cx">     bool inPageCache() const { return m_inPage=
Cache; }
</span><span class=3D"cx">     void setInPageCache(bool flag);
</span></span></pre></div>
<a id=3D"trunkSourceWebCoredomScriptExecutionContexth"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/dom/ScriptExecu=
tionContext.h (149958 =3D> 149959)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/dom/ScriptExecutionContext.=
h	2013-05-12 14:11:47 UTC (rev 149958)
+++ trunk/Source/WebCore/dom/ScriptExecutionContext.h	2013-05-12 14:23:09=
 UTC (rev 149959)
</span><span class=3D"lines">@@ -111,9 +111,6 @@
</span><span class=3D"cx">     void didCreateDestructionObserver(ContextD=
estructionObserver*);
</span><span class=3D"cx">     void willDestroyDestructionObserver(Contex=
tDestructionObserver*);
</span><span class=3D"cx">=20
</span><del>-    virtual void suspendScriptedAnimationControllerCallbacks=
() { }
-    virtual void resumeScriptedAnimationControllerCallbacks() { }
-
</del><span class=3D"cx">     // MessagePort is conceptually a kind of Ac=
tiveDOMObject, but it needs to be tracked separately for message dispatch=
.
</span><span class=3D"cx">     void processMessagePortMessagesSoon();
</span><span class=3D"cx">     void dispatchMessagePortEvents();
</span></span></pre>
</div>
</div>

</body>
</html>