No subject


Mon Jan 28 08:41:14 PST 2013


0175">r150175</a> by &lt;dcheng at chromium.org&gt;
&lt;http://src.chromium.org/viewvc/blink?view=3Drevision&amp;revision=3D1=
50175&gt;

Document::open() already calls Document::removeAllEventListeners(), which
removes the event listeners from the DOMWindow it's attached to, so
there's no need to do it manually here as well.

* dom/Document.cpp:
(WebCore::Document::open):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href=3D"#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeL=
og</a></li>
<li><a href=3D"#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/do=
m/Document.cpp</a></li>
</ul>

</div>
<div id=3D"patch">
<h3>Diff</h3>
<a id=3D"trunkSourceWebCoreChangeLog"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (1499=
56 =3D> 149957)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/ChangeLog	2013-05-12 13:57:=
27 UTC (rev 149956)
+++ trunk/Source/WebCore/ChangeLog	2013-05-12 14:05:37 UTC (rev 149957)
</span><span class=3D"lines">@@ -1,5 +1,19 @@
</span><span class=3D"cx"> 2013-05-12  Andreas Kling  &lt;akling at apple.co=
m&gt;
</span><span class=3D"cx">=20
</span><ins>+        Remove redundant call to removeAllEventListeners() i=
n Document::open().
+
+        From Blink r150175 by &lt;dcheng at chromium.org&gt;
+        &lt;http://src.chromium.org/viewvc/blink?view=3Drevision&amp;rev=
ision=3D150175&gt;
+
+        Document::open() already calls Document::removeAllEventListeners=
(), which
+        removes the event listeners from the DOMWindow it's attached to,=
 so
+        there's no need to do it manually here as well.
+
+        * dom/Document.cpp:
+        (WebCore::Document::open):
+
+2013-05-12  Andreas Kling  &lt;akling at apple.com&gt;
+
</ins><span class=3D"cx">         Apply FINAL to the RenderObject hierarc=
hy.
</span><span class=3D"cx">         &lt;http://webkit.org/b/115977&gt;
</span><span class=3D"cx">=20
</span></span></pre></div>
<a id=3D"trunkSourceWebCoredomDocumentcpp"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cp=
p (149956 =3D> 149957)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/dom/Document.cpp	2013-05-12=
 13:57:27 UTC (rev 149956)
+++ trunk/Source/WebCore/dom/Document.cpp	2013-05-12 14:05:37 UTC (rev 14=
9957)
</span><span class=3D"lines">@@ -2233,9 +2233,6 @@
</span><span class=3D"cx">     if (ScriptableDocumentParser* parser =3D s=
criptableDocumentParser())
</span><span class=3D"cx">         parser-&gt;setWasCreatedByScript(true)=
;
</span><span class=3D"cx">=20
</span><del>-    if (DOMWindow* domWindow =3D this-&gt;domWindow())
-        domWindow-&gt;removeAllEventListeners();
-
</del><span class=3D"cx">     if (m_frame)
</span><span class=3D"cx">         m_frame-&gt;loader()-&gt;didExplicitOp=
en();
</span><span class=3D"cx"> }
</span></span></pre>
</div>
</div>

</body>
</html>


More information about the webkit-changes mailing list