[webkit-changes] [43842] trunk/WebCore

[Adam Roben]

On May 18, 2009, at 5:41 PM, Oliver Hunt wrote:

>> +#if ENABLE(XHTMLMP)
>> +    virtual PassRefPtr<RenderStyle> styleForRenderer();
>> +#else
>>      PassRefPtr<RenderStyle> styleForRenderer();
>> +#endif
>>      virtual bool rendererIsNeeded(RenderStyle*);
> I really don't like this change -- even though it only effects a non- 
> mainstream feature i think this is the only place in webkit where  
> there is an ifdef controlling whether a method is virtual or not.
>

We do something like this for Node::isSVGElement and  
Node::isWMLElement already, so there is precedent.

-Adam

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-changes/attachments/20090518/a0e5bc66/attachment-0001.html>