[webkit-changes] [43842] trunk/WebCore
Oliver Hunt
oliver at apple.com
Mon May 18 17:41:04 PDT 2009
On May 18, 2009, at 4:48 PM, staikos at webkit.org wrote:
> Revision
> 43842
> Author
> staikos at webkit.org
> Date
> 2009-05-18 16:48:30 -0700 (Mon, 18 May 2009)
> Log Message
>
> 2009-05-18 Yichao Yin <yichao.yin at torchmobile.com.cn>
>
> Reviewed by George Staikos (and others).
>
> Add XHTMLMP support to Webkit
> XHTMLMP is a strict subset of XHTML 1.1. It extends XHTML
> Basic and add enhanced
> functionality. Most of the functionalities have already been
> implemented by Webkit.
>
> The changes include:
> 1) Adding <noscript> support
> 2) Document conformance validation
> 3) User Agent conformance validation
Can you please include bug#'s for bugs that have discussion in
bugzilla in future? Otherwise it's hard for us to understand the path
that led to final decisions in the patch
> Modified: trunk/WebCore/dom/Node.h (43841 => 43842)
>
> --- trunk/WebCore/dom/Node.h 2009-05-18 22:35:12 UTC (rev 43841)
> +++ trunk/WebCore/dom/Node.h 2009-05-18 23:48:30 UTC (rev 43842)
> @@ -3,6 +3,7 @@
> * (C) 1999 Antti Koivisto (koivisto at kde.org)
> * (C) 2001 Dirk Mueller (mueller at kde.org)
> * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All
> rights reserved.
> + * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/
> )
> *
> * This library is free software; you can redistribute it and/or
> * modify it under the terms of the GNU Library General Public
> @@ -425,9 +426,13 @@
>
> virtual void willRemove();
> void createRendererIfNeeded();
> +#if ENABLE(XHTMLMP)
> + virtual PassRefPtr<RenderStyle> styleForRenderer();
> +#else
> PassRefPtr<RenderStyle> styleForRenderer();
> +#endif
> virtual bool rendererIsNeeded(RenderStyle*);
I really don't like this change -- even though it only effects a non-
mainstream feature i think this is the only place in webkit where
there is an ifdef controlling whether a method is virtual or not.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-changes/attachments/20090518/7bb518b2/attachment.html>
More information about the webkit-changes
mailing list