[webkit-changes] cvs commit: WebCore/kwq KWQAccObject.mm

[David]

harrison    05/09/14 17:57:26

  Modified:    .        ChangeLog
               kwq      KWQAccObject.mm
  Log:
          Reviewed by Eric.
  
          <rdar://problem/4057623> AX: Dictionary Panel crash in AXAttributeStringSetStyle in Safari (Dictionary has workaround)
  
          Test cases added: None.  Manual testing is way to awkward, and automated testing
          is not possible.  Filed following bug to get automation.
          <rdar://problem/4256882> Need automated testing support for accessibility APIs
  
          * kwq/KWQAccObject.mm:
          (AXAttributedStringAppendText):
  
  Revision  Changes    Path
  1.122     +13 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.121
  retrieving revision 1.122
  diff -u -r1.121 -r1.122
  --- ChangeLog	15 Sep 2005 00:20:58 -0000	1.121
  +++ ChangeLog	15 Sep 2005 00:57:25 -0000	1.122
  @@ -1,3 +1,16 @@
  +2005-09-14  David Harrison  <harrison at apple.com>
  +
  +        Reviewed by Eric.
  +
  +        <rdar://problem/4057623> AX: Dictionary Panel crash in AXAttributeStringSetStyle in Safari (Dictionary has workaround)
  +
  +        Test cases added: None.  Manual testing is way to awkward, and automated testing
  +        is not possible.  Filed following bug to get automation.
  +        <rdar://problem/4256882> Need automated testing support for accessibility APIs
  +
  +        * kwq/KWQAccObject.mm:
  +        (AXAttributedStringAppendText):
  +
   2005-09-14 Vicki Murley  <vicki at apple.com>
   
           Reviewed by Dave Hyatt.
  
  
  
  1.81      +4 -0      WebCore/kwq/KWQAccObject.mm
  
  Index: KWQAccObject.mm
  ===================================================================
  RCS file: /cvs/root/WebCore/kwq/KWQAccObject.mm,v
  retrieving revision 1.80
  retrieving revision 1.81
  diff -u -r1.80 -r1.81
  --- KWQAccObject.mm	3 Sep 2005 23:10:01 -0000	1.80
  +++ KWQAccObject.mm	15 Sep 2005 00:57:26 -0000	1.81
  @@ -1312,6 +1312,10 @@
   
   static void AXAttributedStringAppendText (NSMutableAttributedString *attrString, NodeImpl *nodeImpl, const QChar *chars, int length)
   {
  +    // skip invisible text
  +    if (!nodeImpl->renderer())
  +        return;
  +        
       // easier to calculate the range before appending the string
       NSRange attrStringRange = NSMakeRange([attrString length], length);