[webkit-changes] cvs commit: WebCore ChangeLog

[Vicki]

vicki       05/09/14 17:20:58

  Modified:    khtml/xml dom_nodeimpl.cpp
               .        ChangeLog
  Log:
          Reviewed by Dave Hyatt.
  
  	- fixed <rdar://problem/4255274> REGRESSION: in some cases, link jumping to images is broken (4964)
  
          * khtml/xml/dom_nodeimpl.cpp:
          (DOM::ContainerNodeImpl::getUpperLeftCorner):
  
  Revision  Changes    Path
  1.188     +3 -1      WebCore/khtml/xml/dom_nodeimpl.cpp
  
  Index: dom_nodeimpl.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/xml/dom_nodeimpl.cpp,v
  retrieving revision 1.187
  retrieving revision 1.188
  diff -u -r1.187 -r1.188
  --- dom_nodeimpl.cpp	12 Sep 2005 04:42:29 -0000	1.187
  +++ dom_nodeimpl.cpp	15 Sep 2005 00:20:57 -0000	1.188
  @@ -2235,6 +2235,8 @@
           else if(o->nextSibling())
               o = o->nextSibling();
           else {
  +            // FIXME: If the element we're scrolling to doesn't have a child or next sibling and none of the nodes on 
  +            // the parent chain have siblings, then this loop returns false prematurely - 4256060
               RenderObject *next = 0;
               while(!next) {
                   o = o->parent();
  @@ -2243,7 +2245,7 @@
               }
               o = next;
           }
  -        if (o->parent()->element() == this && !static_cast<RenderText*>(o)->firstTextBox() ) {
  +        if (o->parent()->element() == this && o->isText() && !o->isBR() && !static_cast<RenderText*>(o)->firstTextBox()) {
               // do nothing - skip child node of the named anchor if it doesn't have a text box rdar://problems/4233844&4246096
           }
           else if((o->isText() && !o->isBR()) || o->isReplaced()) {
  
  
  
  1.121     +9 -0      WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.120
  retrieving revision 1.121
  diff -u -r1.120 -r1.121
  --- ChangeLog	14 Sep 2005 21:06:54 -0000	1.120
  +++ ChangeLog	15 Sep 2005 00:20:58 -0000	1.121
  @@ -1,3 +1,12 @@
  +2005-09-14 Vicki Murley  <vicki at apple.com>
  +
  +        Reviewed by Dave Hyatt.
  + 
  +	- fixed <rdar://problem/4255274> REGRESSION: in some cases, link jumping to images is broken (4964)
  +
  +        * khtml/xml/dom_nodeimpl.cpp:
  +        (DOM::ContainerNodeImpl::getUpperLeftCorner): 
  +
   2005-09-14  Darin Adler  <darin at apple.com>
   
           Reviewed by John.