[webkit-changes] cvs commit: WebCore/kwq KWQComboBox.mm KWQListBox.mm

[Timothy]

thatcher    05/11/17 10:32:17

  Modified:    .        Tag: Safari-1-3-branch ChangeLog
               kwq      Tag: Safari-1-3-branch KWQComboBox.mm KWQListBox.mm
  Log:
          Merged fix from TOT to Safari-1-3-branch
  
      2005-11-15  Adele Peterson  <adele at apple.com>
  
          Reviewed by Darin.
  
          - fix for <rdar://problem/4341948> REGRESSION(TOT/GLENDALE): Safari won't tab between input/textarea elements if a select element is present
  
          * kwq/KWQComboBox.mm: (-[KWQPopUpButton canBecomeKeyView]): removed check for tabsToAllControls() since we now always allow tabbing to select elements
          * kwq/KWQListBox.mm: (-[KWQTableView canBecomeKeyView]): ditto.
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.335.2.24 +13 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.335.2.23
  retrieving revision 1.335.2.24
  diff -u -r1.335.2.23 -r1.335.2.24
  --- ChangeLog	16 Nov 2005 01:38:57 -0000	1.335.2.23
  +++ ChangeLog	17 Nov 2005 18:32:11 -0000	1.335.2.24
  @@ -1,3 +1,16 @@
  +2005-11-17  Timothy Hatcher  <timothy at apple.com>
  +
  +        Merged fix from TOT to Safari-1-3-branch
  +
  +    2005-11-15  Adele Peterson  <adele at apple.com>
  +
  +        Reviewed by Darin.
  +
  +        - fix for <rdar://problem/4341948> REGRESSION(TOT/GLENDALE): Safari won't tab between input/textarea elements if a select element is present
  +
  +        * kwq/KWQComboBox.mm: (-[KWQPopUpButton canBecomeKeyView]): removed check for tabsToAllControls() since we now always allow tabbing to select elements
  +        * kwq/KWQListBox.mm: (-[KWQTableView canBecomeKeyView]): ditto.
  +
   2005-11-15  Timothy Hatcher  <timothy at apple.com>
   
           Merged fix from TOT to Safari-1-3-branch
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.59.8.3  +0 -5      WebCore/kwq/KWQComboBox.mm
  
  Index: KWQComboBox.mm
  ===================================================================
  RCS file: /cvs/root/WebCore/kwq/KWQComboBox.mm,v
  retrieving revision 1.59.8.2
  retrieving revision 1.59.8.3
  diff -u -r1.59.8.2 -r1.59.8.3
  --- KWQComboBox.mm	12 Nov 2005 01:57:44 -0000	1.59.8.2
  +++ KWQComboBox.mm	17 Nov 2005 18:32:16 -0000	1.59.8.3
  @@ -501,11 +501,6 @@
   {
       // Simplified method from NSView; overridden to replace NSView's way of checking
       // for full keyboard access with ours.
  -    QWidget *widget = [self widget];
  -    if (widget && !KWQKHTMLPart::partForWidget([self widget])->tabsToAllControls()) {
  -        return NO;
  -    }
  -    
       return ([self window] != nil) && ![self isHiddenOrHasHiddenAncestor] && [self acceptsFirstResponder];
   }
   
  
  
  
  1.51.6.3  +0 -3      WebCore/kwq/KWQListBox.mm
  
  Index: KWQListBox.mm
  ===================================================================
  RCS file: /cvs/root/WebCore/kwq/KWQListBox.mm,v
  retrieving revision 1.51.6.2
  retrieving revision 1.51.6.3
  diff -u -r1.51.6.2 -r1.51.6.3
  --- KWQListBox.mm	12 Nov 2005 01:57:44 -0000	1.51.6.2
  +++ KWQListBox.mm	17 Nov 2005 18:32:16 -0000	1.51.6.3
  @@ -498,9 +498,6 @@
   {
       // Simplified method from NSView; overridden to replace NSView's way of checking
       // for full keyboard access with ours.
  -    if (!_box || !KWQKHTMLPart::partForWidget(_box)->tabsToAllControls()) {
  -        return NO;
  -    }
       return ([self window] != nil) && ![self isHiddenOrHasHiddenAncestor] && [self acceptsFirstResponder];
   }