[webkit-changes] cvs commit: WebCore/kwq KWQComboBox.mm KWQListBox.mm

[Timothy]

thatcher    05/11/17 10:29:08

  Modified:    .        Tag: Safari-2-0-branch ChangeLog
               kwq      Tag: Safari-2-0-branch KWQComboBox.mm KWQListBox.mm
  Log:
          Merged fix from TOT to Safari-2-0-branch
  
      2005-11-15  Adele Peterson  <adele at apple.com>
  
          Reviewed by Darin.
  
          - fix for <rdar://problem/4341948> REGRESSION(TOT/GLENDALE): Safari won't tab between input/textarea elements if a select element is present
  
          * kwq/KWQComboBox.mm: (-[KWQPopUpButton canBecomeKeyView]): removed check for tabsToAllControls() since we now always allow tabbing to select elements
          * kwq/KWQListBox.mm: (-[KWQTableView canBecomeKeyView]): ditto.
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.1.2.68  +13 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.1.2.67
  retrieving revision 1.1.2.68
  diff -u -r1.1.2.67 -r1.1.2.68
  --- ChangeLog	17 Nov 2005 02:01:12 -0000	1.1.2.67
  +++ ChangeLog	17 Nov 2005 18:29:01 -0000	1.1.2.68
  @@ -1,3 +1,16 @@
  +2005-11-17  Timothy Hatcher  <timothy at apple.com>
  +
  +        Merged fix from TOT to Safari-2-0-branch
  +
  +    2005-11-15  Adele Peterson  <adele at apple.com>
  +
  +        Reviewed by Darin.
  +
  +        - fix for <rdar://problem/4341948> REGRESSION(TOT/GLENDALE): Safari won't tab between input/textarea elements if a select element is present
  +
  +        * kwq/KWQComboBox.mm: (-[KWQPopUpButton canBecomeKeyView]): removed check for tabsToAllControls() since we now always allow tabbing to select elements
  +        * kwq/KWQListBox.mm: (-[KWQTableView canBecomeKeyView]): ditto.
  +
   === WebCore-417.6 ===
   
   2005-11-16  Timothy Hatcher  <timothy at apple.com>
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.59.10.7 +0 -5      WebCore/kwq/KWQComboBox.mm
  
  Index: KWQComboBox.mm
  ===================================================================
  RCS file: /cvs/root/WebCore/kwq/KWQComboBox.mm,v
  retrieving revision 1.59.10.6
  retrieving revision 1.59.10.7
  diff -u -r1.59.10.6 -r1.59.10.7
  --- KWQComboBox.mm	12 Nov 2005 01:57:17 -0000	1.59.10.6
  +++ KWQComboBox.mm	17 Nov 2005 18:29:07 -0000	1.59.10.7
  @@ -519,11 +519,6 @@
   {
       // Simplified method from NSView; overridden to replace NSView's way of checking
       // for full keyboard access with ours.
  -    QWidget *widget = [self widget];
  -    if (widget && !KWQKHTMLPart::partForWidget([self widget])->tabsToAllControls()) {
  -        return NO;
  -    }
  -    
       return ([self window] != nil) && ![self isHiddenOrHasHiddenAncestor] && [self acceptsFirstResponder];
   }
   
  
  
  
  1.51.8.8  +0 -3      WebCore/kwq/KWQListBox.mm
  
  Index: KWQListBox.mm
  ===================================================================
  RCS file: /cvs/root/WebCore/kwq/KWQListBox.mm,v
  retrieving revision 1.51.8.7
  retrieving revision 1.51.8.8
  diff -u -r1.51.8.7 -r1.51.8.8
  --- KWQListBox.mm	12 Nov 2005 01:57:18 -0000	1.51.8.7
  +++ KWQListBox.mm	17 Nov 2005 18:29:07 -0000	1.51.8.8
  @@ -535,9 +535,6 @@
   {
       // Simplified method from NSView; overridden to replace NSView's way of checking
       // for full keyboard access with ours.
  -    if (!_box || !KWQKHTMLPart::partForWidget(_box)->tabsToAllControls()) {
  -        return NO;
  -    }
       return ([self window] != nil) && ![self isHiddenOrHasHiddenAncestor] && [self acceptsFirstResponder];
   }