[webkit-changes] cvs commit: WebCore/manual-tests focus-select-when-clicked.html

Mon Jul 25 16:13:36 PDT 2005

vicki       05/07/25 16:13:35

  Modified:    kwq      KWQComboBox.mm
               .        ChangeLog
  Added:       manual-tests focus-select-when-clicked.html
  Log:
          Reviewed by Beth Dakin.

  	- fixed <rdar://problem/4011544> selecting an item from a <select> menu with
  	the mouse doesn't place the focus on the menu

  	Test cases added:
          * manual-tests/focus-select-when-clicked.html: Added.

          * kwq/KWQComboBox.mm:
          (-[KWQPopUpButton needsPanelToBecomeKey]): override this NSView method to return YES

  Revision  Changes    Path
  1.62      +6 -0      WebCore/kwq/KWQComboBox.mm

  Index: KWQComboBox.mm
  ===================================================================
  RCS file: /cvs/root/WebCore/kwq/KWQComboBox.mm,v
  retrieving revision 1.61
  retrieving revision 1.62
  diff -u -r1.61 -r1.62
  --- KWQComboBox.mm	14 Jul 2005 23:53:33 -0000	1.61
  +++ KWQComboBox.mm	25 Jul 2005 23:13:31 -0000	1.62
  @@ -499,6 +499,12 @@
       return resign;
   }

  +- (BOOL)needsPanelToBecomeKey
  +{
  +    // override this NSView method so that <select> elements gain focus when clicked - 4011544
  +    return YES;
  +}
  +
   - (BOOL)canBecomeKeyView
   {
       // Simplified method from NSView; overridden to replace NSView's way of checking

  1.4469    +13 -0     WebCore/ChangeLog

  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.4468
  retrieving revision 1.4469
  diff -u -r1.4468 -r1.4469
  --- ChangeLog	25 Jul 2005 22:17:15 -0000	1.4468
  +++ ChangeLog	25 Jul 2005 23:13:32 -0000	1.4469
  @@ -1,3 +1,16 @@
  +2005-07-25  Vicki Murley  <vicki at apple.com>
  +
  +        Reviewed by Beth Dakin.
  +
  +	- fixed <rdar://problem/4011544> selecting an item from a <select> menu with 
  +	the mouse doesn't place the focus on the menu
  +        
  +	Test cases added: 
  +        * manual-tests/focus-select-when-clicked.html: Added.
  +
  +        * kwq/KWQComboBox.mm:
  +        (-[KWQPopUpButton needsPanelToBecomeKey]): override this NSView method to return YES
  +
   2005-07-24  Maciej Stachowiak  <mjs at apple.com>

           Reviewed by Darin.

  1.1                  WebCore/manual-tests/focus-select-when-clicked.html

  Index: focus-select-when-clicked.html
  ===================================================================
  <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"
          "http://www.w3.org/TR/html4/strict.dtd">
  <html lang="en">
  <head>
  </head>
  <body>
  <p><b>BUG ID:</b> <a href="rdar://problem/4011544">4011544</a> selecting an item from a select menu with the mouse doesn't place the focus on the menu</p>

STEPS TO TEST: 
 1. Click on the pop-up menu below titled "Click Here", and select OPTION 1 from the list. 
 2. Verify that a blue focus ring is drawn around the pop-up menu. 
 3. Press tab, and verify that focus moves to TEXT AREA 2

  <p id="success" style="background-color:palegreen; padding:3px;"><b>TEST PASS:</b> 
  Blue focus ring is drawn around the pop-up menu when clicked, then focus moves to TEXT AREA 2 after pressing tab.</p>

TEST FAIL: 
 No blue focus ring drawn around the pop-up menu when clicked, or after selecting OPTION 1 from the list. After selecting option 1 and pressing tab, focus will land on the first focusable element on the page.

  <input type="text" value="TEXT AREA 1">
  <select>
  	<option>Click Here</option>
  	<option>OPTION 1</option>
  </select>
  <input type="text" value="TEXT AREA 2">

  </body>
  </html>