[webkit-changes] cvs commit: LayoutTests/fast/forms button-in-forms-collection-expected.txt button-in-forms-collection.html

[Maciej]

mjs         05/12/27 04:05:35

  Modified:    .        ChangeLog
               .        ChangeLog
               khtml/html html_formimpl.h
  Added:       fast/forms button-in-forms-collection-expected.txt
                        button-in-forms-collection.html
  Log:
  LayoutTests:
  
          Reviewed, tweaked and landed by Maciej.
  
  	- test case for 4405: <button> not listed in form collections.
  	http://bugzilla.opendarwin.org/show_bug.cgi?id=4405
  
          * fast/forms/button-in-forms-collection-expected.txt: Added.
          * fast/forms/button-in-forms-collection.html: Added.
  
  WebCore:
  
          Reviewed and landed by Maciej.
  
  	- fixed 4405: <button> not listed in form collections.
  	http://bugzilla.opendarwin.org/show_bug.cgi?id=4405
  
  	Test: fast/forms/button-in-forms-collection.html
  
          * khtml/html/html_formimpl.h:
          (DOM::HTMLButtonElementImpl::isEnumeratable): override to return true
  
  Revision  Changes    Path
  1.188     +10 -0     LayoutTests/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/LayoutTests/ChangeLog,v
  retrieving revision 1.187
  retrieving revision 1.188
  diff -u -r1.187 -r1.188
  --- ChangeLog	27 Dec 2005 11:07:48 -0000	1.187
  +++ ChangeLog	27 Dec 2005 12:05:33 -0000	1.188
  @@ -2,6 +2,16 @@
   
           Reviewed, tweaked and landed by Maciej.
   
  +	- test case for 4405: <button> not listed in form collections.
  +	http://bugzilla.opendarwin.org/show_bug.cgi?id=4405
  +
  +        * fast/forms/button-in-forms-collection-expected.txt: Added.
  +        * fast/forms/button-in-forms-collection.html: Added.
  +
  +2005-12-27  Maks Orlovich <maksim at kde.org>
  +
  +        Reviewed, tweaked and landed by Maciej.
  +
   	- test case for 6234: Can delete array index property incorrectly.
   	http://bugzilla.opendarwin.org/show_bug.cgi?id=6234
   
  
  
  
  1.43      +12 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.42
  retrieving revision 1.43
  diff -u -r1.42 -r1.43
  --- ChangeLog	26 Dec 2005 21:46:16 -0000	1.42
  +++ ChangeLog	27 Dec 2005 12:05:34 -0000	1.43
  @@ -1,3 +1,15 @@
  +2005-12-27  Maks Orlovich <maksim at kde.org>
  +
  +        Reviewed and landed by Maciej.
  +
  +	- fixed 4405: <button> not listed in form collections.
  +	http://bugzilla.opendarwin.org/show_bug.cgi?id=4405
  +
  +	Test: fast/forms/button-in-forms-collection.html
  +	
  +        * khtml/html/html_formimpl.h:
  +        (DOM::HTMLButtonElementImpl::isEnumeratable): override to return true
  +
   2005-12-25  Maciej Stachowiak  <mjs at apple.com>
   
           Reviewed by Geoff.
  
  
  
  1.101     +2 -0      WebCore/khtml/html/html_formimpl.h
  
  Index: html_formimpl.h
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/html/html_formimpl.h,v
  retrieving revision 1.100
  retrieving revision 1.101
  diff -u -r1.100 -r1.101
  --- html_formimpl.h	22 Dec 2005 23:06:20 -0000	1.100
  +++ html_formimpl.h	27 Dec 2005 12:05:34 -0000	1.101
  @@ -249,6 +249,8 @@
       virtual void defaultEventHandler(EventImpl *evt);
       virtual bool appendFormData(FormDataList&, bool);
   
  +    virtual bool isEnumeratable() const { return true; } 
  +
       virtual bool isSuccessfulSubmitButton() const;
       virtual bool isActivatedSubmit() const;
       virtual void setActivatedSubmit(bool flag);
  
  
  
  1.1                  LayoutTests/fast/forms/button-in-forms-collection-expected.txt
  
  Index: button-in-forms-collection-expected.txt
  ===================================================================
  The following tests for regression against 4405: <button> not listed in form collections. You should see a series of lines starting with PASS.
  
   Button2
  PASS document.test.elements.length is 2
  PASS document.test.elements[0].name is "foo"
  PASS document.test.elements[1].name is "bla"
  PASS document.test.foo.value is "Button1"
  PASS document.test.bla.value is "Button2"
  
  
  
  
  1.1                  LayoutTests/fast/forms/button-in-forms-collection.html
  
  Index: button-in-forms-collection.html
  ===================================================================
  <!-- Based on testcase from KDE bug #110629, heavily modified -->
  <html>  <head> 
  
  <script src="../js/kde/resources/base.js"></script>
  <script>
  if (window.layoutTestController)
      layoutTestController.dumpAsText();
  
  function testPassed(msg)
  {
      document.write("<b><font color=green>PASS</font></b> " + msg + "<br>");
  }
  
  function testFailed(msg)
  {
      document.write("<b><font color=red>FAIL</font></b> " + msg + "<br>");
  }
  
  function debug(a) 
  { 
      document.write("<p> " + a + "</p>"); 
  }
  </script>
     </head> 
  
     <body> 
  <p>The following tests for regression against <a href="http://bugzilla.opendarwin.org/show_bug.cgi?id=4405">4405: &lt;button&gt; not listed in form collections.</a> You should see a series of lines starting with PASS.</p>
     
       <form name="test"> 
       <input type="button" name="foo" id="foo" value="Button1"> 
       <button type="button" name="bla" id="bla" value="Button2">Button2</button> 
       </form> 
  
  <br>
   <script> 
      shouldBe("document.test.elements.length", "2");
      shouldBe("document.test.elements[0].name", '"foo"');
      shouldBe("document.test.elements[1].name", '"bla"');
      shouldBe("document.test.foo.value", '"Button1"');
      shouldBe("document.test.bla.value", '"Button2"');
   </script> 
  
     </body> 
   </html>