[webkit-changes] cvs commit: LayoutTests/fast/js
array-float-delete.html
Maciej
mjs at opensource.apple.com
Tue Dec 27 03:07:49 PST 2005
mjs 05/12/27 03:07:49
Modified: . ChangeLog
kjs array_object.cpp
. ChangeLog
Added: fast/js array-float-delete.html
Log:
JavaScriptCore:
Reviewed and landed by Maciej.
- fixed 6234: Can delete array index property incorrectly.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6234
* kjs/array_object.cpp:
(ArrayInstance::deleteProperty): use toArrayIndex instead of toUInt32 when
looking for array properties.
LayoutTests:
Reviewed, tweaked and landed by Maciej.
- test case for 6234: Can delete array index property incorrectly.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6234
* fast/js/array-float-delete.html: Added.
Revision Changes Path
1.932 +11 -0 JavaScriptCore/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/JavaScriptCore/ChangeLog,v
retrieving revision 1.931
retrieving revision 1.932
diff -u -r1.931 -r1.932
--- ChangeLog 27 Dec 2005 10:35:54 -0000 1.931
+++ ChangeLog 27 Dec 2005 11:07:45 -0000 1.932
@@ -1,3 +1,14 @@
+2005-12-27 Maks Orlovich <maksim at kde.org>
+
+ Reviewed and landed by Maciej.
+
+ - fixed 6234: Can delete array index property incorrectly.
+ http://bugzilla.opendarwin.org/show_bug.cgi?id=6234
+
+ * kjs/array_object.cpp:
+ (ArrayInstance::deleteProperty): use toArrayIndex instead of toUInt32 when
+ looking for array properties.
+
2005-12-27 Anders Carlsson <andersca at mac.com>
Reviewed by Maciej.
1.61 +1 -1 JavaScriptCore/kjs/array_object.cpp
Index: array_object.cpp
===================================================================
RCS file: /cvs/root/JavaScriptCore/kjs/array_object.cpp,v
retrieving revision 1.60
retrieving revision 1.61
diff -u -r1.60 -r1.61
--- array_object.cpp 23 Dec 2005 01:52:42 -0000 1.60
+++ array_object.cpp 27 Dec 2005 11:07:48 -0000 1.61
@@ -161,7 +161,7 @@
return false;
bool ok;
- uint32_t index = propertyName.toUInt32(&ok);
+ uint32_t index = propertyName.toArrayIndex(&ok);
if (ok) {
if (index >= length)
return true;
1.187 +9 -0 LayoutTests/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/LayoutTests/ChangeLog,v
retrieving revision 1.186
retrieving revision 1.187
diff -u -r1.186 -r1.187
--- ChangeLog 26 Dec 2005 23:07:04 -0000 1.186
+++ ChangeLog 27 Dec 2005 11:07:48 -0000 1.187
@@ -1,3 +1,12 @@
+2005-12-27 Maks Orlovich <maksim at kde.org>
+
+ Reviewed, tweaked and landed by Maciej.
+
+ - test case for 6234: Can delete array index property incorrectly.
+ http://bugzilla.opendarwin.org/show_bug.cgi?id=6234
+
+ * fast/js/array-float-delete.html: Added.
+
2005-12-26 Maciej Stachowiak <mjs at apple.com>
Rubber stamped by Geoff.
1.1 LayoutTests/fast/js/array-float-delete.html
Index: array-float-delete.html
===================================================================
<html>
<body>
<p>This test checks for regression against <a href="http://bugzilla.opendarwin.org/show_bug.cgi?id=6234">6234: Can delete array index property incorrectly.</a></p>
<p>On success, you will see a series of "PASS" messages.</p>
<script src="kde/resources/base.js"></script>
<script>
if (window.layoutTestController)
layoutTestController.dumpAsText();
function testPassed(msg)
{
document.write("<b><font color=green>PASS</font></b> " + msg + "<br>");
}
function testFailed(msg)
{
document.write("<b><font color=red>FAIL</font></b> " + msg + "<br>");
}
function debug(a)
{
document.write("<p> " + a + "</p>");
}
</script>
<pre>
<script>
var a = new Array();
a[1] = "before";
a['1.0'] = "after";
delete a['1.0'];
shouldBe("a[1]", '"before"');
</script>
</pre>
</body>
More information about the webkit-changes
mailing list