[webkit-changes] cvs commit: WebCore/khtml/editing apply_style_command.cpp

[David]

harrison    05/12/20 14:31:45

  Modified:    .        ChangeLog
               khtml/editing apply_style_command.cpp
  Log:
          <rdar://problem/4294417> Cannot un-italicize some text after triple clicking it
  
          Reviewed by Justin.
  
          * khtml/editing/apply_style_command.cpp:
          (khtml::ApplyStyleCommand::addInlineStyleIfNeeded):
          Removed check for tab span because ApplyStyleCommand::removeCSSStyle() already makes the same check.
  
  Revision  Changes    Path
  1.14      +10 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- ChangeLog	20 Dec 2005 21:18:27 -0000	1.13
  +++ ChangeLog	20 Dec 2005 22:31:44 -0000	1.14
  @@ -1,3 +1,13 @@
  +2005-12-20  David Harrison  <harrison at apple.com>
  +
  +        <rdar://problem/4294417> Cannot un-italicize some text after triple clicking it
  +
  +        Reviewed by Justin.
  +
  +        * khtml/editing/apply_style_command.cpp:
  +        (khtml::ApplyStyleCommand::addInlineStyleIfNeeded):
  +        Removed check for tab span because ApplyStyleCommand::removeCSSStyle() already makes the same check.
  +        
   2005-12-20  Justin Garcia  <justin.garcia at apple.com>
   
           <rdar://problem/4387270> editing/deleting/delete-3800834-fix failing
  
  
  
  1.20      +0 -4      WebCore/khtml/editing/apply_style_command.cpp
  
  Index: apply_style_command.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/editing/apply_style_command.cpp,v
  retrieving revision 1.19
  retrieving revision 1.20
  diff -u -r1.19 -r1.20
  --- apply_style_command.cpp	1 Dec 2005 10:32:14 -0000	1.19
  +++ apply_style_command.cpp	20 Dec 2005 22:31:44 -0000	1.20
  @@ -1199,10 +1199,6 @@
       StyleChange styleChange(style, Position(startNode, 0), StyleChange::styleModeForParseMode(document()->inCompatMode()));
       int exceptionCode = 0;
       
  -    // Prevent style changes to our tab spans, because it might remove the whitespace:pre we are after
  -    if (isTabSpanTextNode(startNode))
  -        return;
  -    
       //
       // Font tags need to go outside of CSS so that CSS font sizes override leagcy font sizes.
       //