[webkit-changes] cvs commit: WebKit/WebCoreSupport.subproj WebTextRenderer.m

[Justin]

justing     05/12/20 13:36:40

  Modified:    .        ChangeLog
               WebCoreSupport.subproj WebTextRenderer.m
  Log:
          Reviewed by mitz
  
          Fixed more uninitialized variable warnings, and
          removed an extra semicolon.
  
          * WebCoreSupport.subproj/WebTextRenderer.m:
          (overrideLayoutOperation):
          (createATSULayoutParameters):
  
  Revision  Changes    Path
  1.3420    +11 -0     WebKit/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebKit/ChangeLog,v
  retrieving revision 1.3419
  retrieving revision 1.3420
  diff -u -r1.3419 -r1.3420
  --- ChangeLog	20 Dec 2005 20:42:41 -0000	1.3419
  +++ ChangeLog	20 Dec 2005 21:36:37 -0000	1.3420
  @@ -1,3 +1,14 @@
  +2005-12-20  Justin Garcia  <justin.garcia at apple.com>
  +
  +        Reviewed by mitz
  +        
  +        Fixed more uninitialized variable warnings, and 
  +        removed an extra semicolon.
  +
  +        * WebCoreSupport.subproj/WebTextRenderer.m:
  +        (overrideLayoutOperation):
  +        (createATSULayoutParameters):
  +
   2005-12-20  Maciej Stachowiak  <mjs at apple.com>
   
           Reviewed by Darin.
  
  
  
  1.208     +4 -4      WebKit/WebCoreSupport.subproj/WebTextRenderer.m
  
  Index: WebTextRenderer.m
  ===================================================================
  RCS file: /cvs/root/WebKit/WebCoreSupport.subproj/WebTextRenderer.m,v
  retrieving revision 1.207
  retrieving revision 1.208
  diff -u -r1.207 -r1.208
  --- WebTextRenderer.m	20 Dec 2005 18:29:13 -0000	1.207
  +++ WebTextRenderer.m	20 Dec 2005 21:36:40 -0000	1.208
  @@ -241,10 +241,10 @@
           UniChar ch, nextCh;
           ByteCount offset = layoutRecords[0].originalOffset;
           nextCh = *(UniChar *)(((char *)characters)+offset);
  -        bool shouldRound;
  +        bool shouldRound = false;
           bool syntheticBoldPass = params->syntheticBoldPass;
  -        Fixed syntheticBoldOffset;
  -        ATSGlyphRef spaceGlyph;
  +        Fixed syntheticBoldOffset = 0;
  +        ATSGlyphRef spaceGlyph = 0;
           // In the CoreGraphics code path, the rounding hack is applied in logical order.
           // Here it is applied in visual left-to-right order, which may be better.
           ItemCount i;
  @@ -1289,7 +1289,7 @@
       UniCharArrayOffset substituteOffset = runFrom;
       UniCharCount substituteLength;
       UniCharArrayOffset lastOffset;
  -    WebTextRenderer *substituteRenderer = 0;;
  +    WebTextRenderer *substituteRenderer = 0;
   
       while (substituteOffset < runTo) {
           lastOffset = substituteOffset;