[webkit-changes] cvs commit: WebCore/manual-tests scrollbar-hittest2.html

Mon Dec 19 11:41:39 PST 2005

bdakin      05/12/19 11:41:39

  Modified:    .        ChangeLog
               khtml/rendering render_block.cpp
  Added:       manual-tests scrollbar-hittest2.html
  Log:
  Bug #:

  Revision  Changes    Path
  1.3       +13 -0     WebCore/ChangeLog

  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- ChangeLog	19 Dec 2005 19:17:32 -0000	1.2
  +++ ChangeLog	19 Dec 2005 19:41:38 -0000	1.3
  @@ -1,3 +1,16 @@
  +2005-12-19  Mitz Pettel  <opendarwin.org at mitzpettel.com>
  +
  +        Reviewed by Beth
  +
  +	- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6149
  +          REGRESSION (WebCore-417.5): horizontal scrollbar in overflow with top
  +          border doesn't receive mouse events
  +
  +        * khtml/rendering/render_block.cpp:
  +        (khtml::RenderBlock::isPointInScrollbar):
  +	Removed borderTop() from horizontal scrollbar rect computation.
  +	* manual-tests/scrollbar-hittest2.html: Added.
  +
   2005-12-19  Alexey Proskuryakov  <ap at nypop.com>

           Reviewed by Darin, committed by Adele.

  1.220     +1 -1      WebCore/khtml/rendering/render_block.cpp

  Index: render_block.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/rendering/render_block.cpp,v
  retrieving revision 1.219
  retrieving revision 1.220
  diff -u -r1.219 -r1.220
  --- render_block.cpp	10 Dec 2005 20:21:56 -0000	1.219
  +++ render_block.cpp	19 Dec 2005 19:41:38 -0000	1.220
  @@ -2437,7 +2437,7 @@

       if (m_layer->horizontalScrollbarHeight()) {
           QRect horizRect(_tx + borderLeft(),
  -                        _ty + height() + borderTop() + borderBottomExtra() - m_layer->horizontalScrollbarHeight() - borderBottom(),
  +                        _ty + height() + borderBottomExtra() - m_layer->horizontalScrollbarHeight() - borderBottom(),
                           width() - borderLeft() - borderRight(),
                           m_layer->horizontalScrollbarHeight());
           if (horizRect.contains(_x, _y)) {

  1.1                  WebCore/manual-tests/scrollbar-hittest2.html

  Index: scrollbar-hittest2.html
  ===================================================================
  <html>
  <head>
  <title></title>
  </head>
  <body>
  <p><b>BUG ID:</b> <a href="http://bugzilla.opendarwin.org/show_bug.cgi?id=6149">http://bugzilla.opendarwin.org/show_bug.cgi?id=6149</a> REGRESSION (WebCore-417.5): horizontal scrollbar in overflow with top border doesn't receive mouse events</p>

  <p id="test" style="background-color:skyblue; padding:3px;"><b>TO TEST:</b> <br>
  Scroll right by clicking in the empty space to the right of the scroll thumb.</p>

  <p id="success" style="background-color:palegreen; padding:3px;"><b>TEST PASS:</b> 
  Scroll thumb will move to the right.
  </p>

  <p id="failure" style="background-color:#FF3300; padding:3px;"><b>TEST FAIL:</b>  
  Scroll thumb will NOT move at all.
  <div id="target" style="width: 400px; overflow: auto; border-top: 20px solid grey; border-bottom: 10px solid blue;">
      <div style="width: 600 px; height: 20px; background: green;"></div>
  </div>
  </body>
  </html>