[webkit-changes] cvs commit: WebKit/WebCoreSupport.subproj
WebTextRenderer.m
Adele
adele at opensource.apple.com
Mon Dec 19 11:37:59 PST 2005
adele 05/12/19 11:37:59
Modified: . ChangeLog
. ChangeLog
WebCoreSupport.subproj WebTextRenderer.m
Added: fast/text should-use-atsui-expected.checksum
should-use-atsui-expected.png
should-use-atsui-expected.txt should-use-atsui.html
Log:
LayoutTests:
Reviewed by Darin, committed by Adele.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6132
Incorrect selection highlighting for ATSUI text when selected range is "CG-safe"
* fast/text/should-use-atsui-expected.checksum: Added.
* fast/text/should-use-atsui-expected.png: Added.
* fast/text/should-use-atsui-expected.txt: Added.
* fast/text/should-use-atsui.html: Added.
WebKit:
Reviewed by Darin, committed by Adele.
Test: fast/text/should-use-atsui.html
- fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6132
Incorrect selection highlighting for ATSUI text when selected range is "CG-safe"
* WebCoreSupport.subproj/WebTextRenderer.m:
(shouldUseATSU): Always start scanning from 0 since drawing and
highlighting also measure everything up to run->from.
Revision Changes Path
1.170 +12 -0 LayoutTests/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/LayoutTests/ChangeLog,v
retrieving revision 1.169
retrieving revision 1.170
diff -u -r1.169 -r1.170
--- ChangeLog 19 Dec 2005 00:27:28 -0000 1.169
+++ ChangeLog 19 Dec 2005 19:37:47 -0000 1.170
@@ -1,3 +1,15 @@
+2005-12-19 Mitz Pettel <opendarwin.org at mitzpettel.com>
+
+ Reviewed by Darin, committed by Adele.
+
+ - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6132
+ Incorrect selection highlighting for ATSUI text when selected range is "CG-safe"
+
+ * fast/text/should-use-atsui-expected.checksum: Added.
+ * fast/text/should-use-atsui-expected.png: Added.
+ * fast/text/should-use-atsui-expected.txt: Added.
+ * fast/text/should-use-atsui.html: Added.
+
2005-12-18 Justin Haygood <justin at xiondigital.net>
Reviewed, tweaked, and landed by Darin.
1.1 LayoutTests/fast/text/should-use-atsui-expected.checksum
Index: should-use-atsui-expected.checksum
===================================================================
4b6efdd3fd3f17ec61449f4f53bccd24
1.1 LayoutTests/fast/text/should-use-atsui-expected.png
<<Binary file>>
1.1 LayoutTests/fast/text/should-use-atsui-expected.txt
Index: should-use-atsui-expected.txt
===================================================================
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
layer at (0,0) size 800x600
RenderCanvas at (0,0) size 800x600
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x584
RenderBlock {P} at (0,0) size 784x36
RenderText {TEXT} at (0,0) size 53x18
text run at (0,0) width 53: "Test for "
RenderInline {I} at (0,0) size 736x36
RenderText {TEXT} at (53,0) size 736x36
text run at (53,0) width 683: "http://bugzilla.opendarwin.org/show_bug.cgi?id=6132 Incorrect selection highlighting for ATSUI text when"
text run at (0,18) width 176: "selected range is \"CG-safe\""
RenderText {TEXT} at (176,18) size 4x18
text run at (176,18) width 4: "."
RenderBlock {P} at (0,52) size 784x18
RenderText {TEXT} at (0,0) size 709x18
text run at (0,0) width 709: "The word \x{201C}dolor\x{201D} below should be highlighted in its entirety. The highlight should not extend beyond that word."
RenderBlock {HR} at (0,86) size 784x2 [border: (1px inset #000000)]
RenderBlock (anonymous) at (0,96) size 784x18
RenderInline {SPAN} at (0,0) size 173x18
RenderText {TEXT} at (0,0) size 173x18
text run at (0,0) width 173: "Lo\x{308}re\x{300}m ipsum dolor sit amet"
RenderText {TEXT} at (0,0) size 0x0
RenderText {TEXT} at (0,0) size 0x0
selection start: position 14 of child 0 {TEXT} of child 7 {SPAN} of child 1 {BODY} of child 0 {HTML} of document
selection end: position 19 of child 0 {TEXT} of child 7 {SPAN} of child 1 {BODY} of child 0 {HTML} of document
1.1 LayoutTests/fast/text/should-use-atsui.html
Index: should-use-atsui.html
===================================================================
<html>
<head>
<title></title>
<script type="text/javascript">
function test()
{
var t = document.getElementById("t").firstChild;
window.getSelection().setBaseAndExtent(t, 14, t, 19);
}
</script>
</head>
<body onload="test()">
<p>
Test for <i>http://bugzilla.opendarwin.org/show_bug.cgi?id=6132
Incorrect selection highlighting for ATSUI text when selected range is
"CG-safe"</i>.
</p>
<p>
The word “dolor” below should be highlighted in its entirety. The
highlight should not extend beyond that word.
</p>
<hr>
<span id="t">Lörèm ipsum dolor sit amet</span>
</body>
1.3409 +13 -0 WebKit/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/WebKit/ChangeLog,v
retrieving revision 1.3408
retrieving revision 1.3409
diff -u -r1.3408 -r1.3409
--- ChangeLog 19 Dec 2005 10:32:04 -0000 1.3408
+++ ChangeLog 19 Dec 2005 19:37:49 -0000 1.3409
@@ -1,3 +1,16 @@
+2005-12-19 Mitz Pettel <opendarwin.org at mitzpettel.com>
+
+ Reviewed by Darin, committed by Adele.
+
+ Test: fast/text/should-use-atsui.html
+
+ - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6132
+ Incorrect selection highlighting for ATSUI text when selected range is "CG-safe"
+
+ * WebCoreSupport.subproj/WebTextRenderer.m:
+ (shouldUseATSU): Always start scanning from 0 since drawing and
+ highlighting also measure everything up to run->from.
+
2005-12-17 Maciej Stachowiak <mjs at apple.com>
Rubber stamped by Eric.
1.204 +2 -1 WebKit/WebCoreSupport.subproj/WebTextRenderer.m
Index: WebTextRenderer.m
===================================================================
RCS file: /cvs/root/WebKit/WebCoreSupport.subproj/WebTextRenderer.m,v
retrieving revision 1.203
retrieving revision 1.204
diff -u -r1.203 -r1.204
--- WebTextRenderer.m 17 Dec 2005 18:10:34 -0000 1.203
+++ WebTextRenderer.m 19 Dec 2005 19:37:58 -0000 1.204
@@ -1859,7 +1859,8 @@
const UniChar *characters = run->characters;
int to = run->to;
int i;
- for (i = run->from; i < to; i++) {
+ // Start from 0 since drawing and highlighting also measure the characters before run->from
+ for (i = 0; i < to; i++) {
UniChar c = characters[i];
if (c < 0x300) // U+0300 through U+036F Combining diacritical marks
continue;
More information about the webkit-changes
mailing list