[webkit-changes] cvs commit: WebCore/khtml/ecma kjs_html.cpp

[Geoffrey]

ggaren      05/12/15 22:39:58

  Modified:    .        ChangeLog
               khtml/ecma kjs_html.cpp
  Log:
          Fixed <rdar://problem/4381444> Remove GMail-specific work-around
          previously added.
  
          Reviewed by Darin.
  
          No test case because this patch just turns on already-tested behavior
          for GMail.
  
          * khtml/ecma/kjs_html.cpp:
          (KJS::HTMLElement::textAreaGetter): Removed code that hid the
          selectionEnd property from sites on the GMail domain.
  
  Revision  Changes    Path
  1.542     +14 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.541
  retrieving revision 1.542
  diff -u -r1.541 -r1.542
  --- ChangeLog	16 Dec 2005 06:33:32 -0000	1.541
  +++ ChangeLog	16 Dec 2005 06:39:55 -0000	1.542
  @@ -1,3 +1,17 @@
  +2005-12-15  Geoffrey Garen  <ggaren at apple.com>
  +
  +        Fixed <rdar://problem/4381444> Remove GMail-specific work-around 
  +        previously added.
  +
  +        Reviewed by Darin.
  +
  +        No test case because this patch just turns on already-tested behavior
  +        for GMail.
  +
  +        * khtml/ecma/kjs_html.cpp:
  +        (KJS::HTMLElement::textAreaGetter): Removed code that hid the
  +        selectionEnd property from sites on the GMail domain.
  +
   2005-12-15  Darin Adler  <darin at apple.com>
   
           Reviewed by Eric.
  
  
  
  1.156     +1 -8      WebCore/khtml/ecma/kjs_html.cpp
  
  Index: kjs_html.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/ecma/kjs_html.cpp,v
  retrieving revision 1.155
  retrieving revision 1.156
  diff -u -r1.155 -r1.156
  --- kjs_html.cpp	14 Dec 2005 23:31:45 -0000	1.155
  +++ kjs_html.cpp	16 Dec 2005 06:39:57 -0000	1.156
  @@ -1682,14 +1682,7 @@
           case TextAreaReadOnly:        return jsBoolean(textarea.readOnly());
           case TextAreaRows:            return jsNumber(textarea.rows());
           case TextAreaSelectionStart:  return jsNumber(textarea.selectionStart());
  -        case TextAreaSelectionEnd:
  -            // FIXME (4363497): Work-around to prevent regression caused by GMail bug (4344954).
  -            // For the love of all that is holy, let's remove this code as soon as
  -            // Google fixes its bug.
  -            if (impl() && impl()->getDocument() && (impl()->getDocument()->domain() == "mail.google.com"))
  -                    return jsUndefined();
  -            
  -            return jsNumber(textarea.selectionEnd());
  +        case TextAreaSelectionEnd:    return jsNumber(textarea.selectionEnd());
           case TextAreaTabIndex:        return jsNumber(textarea.tabIndex());
           case TextAreaType:            return jsString(textarea.type());
           case TextAreaValue:           return jsString(textarea.value());