[webkit-changes] cvs commit: WebCore/khtml/html html_formimpl.cpp
Timothy
thatcher at opensource.apple.com
Mon Dec 12 15:49:54 PST 2005
thatcher 05/12/12 15:49:54
Modified: . Tag: Safari-1-3-branch ChangeLog
khtml/html Tag: Safari-1-3-branch html_formimpl.cpp
Log:
Merged fix from TOT to Safari-1-3-branch
2005-12-12 Eric Seidel <eseidel at apple.com>
Reviewed by ggaren.
Test: fast/forms/textarea-setinnerhtml.html
Fixes setInnerHTML for <textarea>
<rdar://problem/4372143>
* khtml/html/html_formimpl.cpp:
(DOM::HTMLTextAreaElementImpl::setValue):
Revision Changes Path
No revision
No revision
1.335.2.50 +16 -0 WebCore/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/WebCore/ChangeLog,v
retrieving revision 1.335.2.49
retrieving revision 1.335.2.50
diff -u -r1.335.2.49 -r1.335.2.50
--- ChangeLog 5 Dec 2005 19:56:49 -0000 1.335.2.49
+++ ChangeLog 12 Dec 2005 23:49:43 -0000 1.335.2.50
@@ -1,3 +1,19 @@
+2005-12-12 Timothy Hatcher <timothy at apple.com>
+
+ Merged fix from TOT to Safari-1-3-branch
+
+ 2005-12-12 Eric Seidel <eseidel at apple.com>
+
+ Reviewed by ggaren.
+
+ Test: fast/forms/textarea-setinnerhtml.html
+
+ Fixes setInnerHTML for <textarea>
+ <rdar://problem/4372143>
+
+ * khtml/html/html_formimpl.cpp:
+ (DOM::HTMLTextAreaElementImpl::setValue):
+
2005-12-05 Timothy Hatcher <timothy at apple.com>
Merged fix from TOT to Safari-1-3-branch
No revision
No revision
1.156.4.8 +3 -1 WebCore/khtml/html/html_formimpl.cpp
Index: html_formimpl.cpp
===================================================================
RCS file: /cvs/root/WebCore/khtml/html/html_formimpl.cpp,v
retrieving revision 1.156.4.7
retrieving revision 1.156.4.8
diff -u -r1.156.4.7 -r1.156.4.8
--- html_formimpl.cpp 1 Dec 2005 18:34:33 -0000 1.156.4.7
+++ html_formimpl.cpp 12 Dec 2005 23:49:52 -0000 1.156.4.8
@@ -3276,9 +3276,11 @@
{
m_value = value.string();
m_valueMatchesRenderer = false;
+ m_valueIsValid = true;
if (m_render)
static_cast<RenderTextArea *>(m_render)->updateFromElement();
- m_valueIsValid = false; // force the next access to fetch from the renderer
+ // FIXME: Force reload from renderer, as renderer may have normalized line endings.
+ m_valueIsValid = false;
setChanged(true);
}
More information about the webkit-changes
mailing list