[webkit-changes] cvs commit: WebCore/khtml/html html_formimpl.cpp
Timothy
thatcher at opensource.apple.com
Mon Dec 12 15:48:02 PST 2005
thatcher 05/12/12 15:48:02
Modified: . Tag: Safari-2-0-branch ChangeLog
khtml/html Tag: Safari-2-0-branch html_formimpl.cpp
Log:
Merged fix from TOT to Safari-2-0-branch
2005-12-12 Eric Seidel <eseidel at apple.com>
Reviewed by ggaren.
Test: fast/forms/textarea-setinnerhtml.html
Fixes setInnerHTML for <textarea>
<rdar://problem/4372143>
* khtml/html/html_formimpl.cpp:
(DOM::HTMLTextAreaElementImpl::setValue):
Revision Changes Path
No revision
No revision
1.1.2.101 +16 -0 WebCore/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/WebCore/ChangeLog,v
retrieving revision 1.1.2.100
retrieving revision 1.1.2.101
diff -u -r1.1.2.100 -r1.1.2.101
--- ChangeLog 12 Dec 2005 19:07:01 -0000 1.1.2.100
+++ ChangeLog 12 Dec 2005 23:47:52 -0000 1.1.2.101
@@ -1,3 +1,19 @@
+2005-12-12 Timothy Hatcher <timothy at apple.com>
+
+ Merged fix from TOT to Safari-2-0-branch
+
+ 2005-12-12 Eric Seidel <eseidel at apple.com>
+
+ Reviewed by ggaren.
+
+ Test: fast/forms/textarea-setinnerhtml.html
+
+ Fixes setInnerHTML for <textarea>
+ <rdar://problem/4372143>
+
+ * khtml/html/html_formimpl.cpp:
+ (DOM::HTMLTextAreaElementImpl::setValue):
+
2005-12-12 Adele Peterson <adele at apple.com>
Reviewed by Dave Harrison.
No revision
No revision
1.156.6.9 +3 -1 WebCore/khtml/html/html_formimpl.cpp
Index: html_formimpl.cpp
===================================================================
RCS file: /cvs/root/WebCore/khtml/html/html_formimpl.cpp,v
retrieving revision 1.156.6.8
retrieving revision 1.156.6.9
diff -u -r1.156.6.8 -r1.156.6.9
--- html_formimpl.cpp 1 Dec 2005 18:26:51 -0000 1.156.6.8
+++ html_formimpl.cpp 12 Dec 2005 23:48:00 -0000 1.156.6.9
@@ -3280,9 +3280,11 @@
{
m_value = value.string();
m_valueMatchesRenderer = false;
+ m_valueIsValid = true;
if (m_render)
static_cast<RenderTextArea *>(m_render)->updateFromElement();
- m_valueIsValid = false; // force the next access to fetch from the renderer
+ // FIXME: Force reload from renderer, as renderer may have normalized line endings.
+ m_valueIsValid = false;
setChanged(true);
}
More information about the webkit-changes
mailing list