[webkit-changes] cvs commit: WebCore/khtml/editing markup.cpp

[David]

harrison    05/08/22 13:24:40

  Modified:    .        ChangeLog
               khtml/editing markup.cpp
  Log:
          Reviewed by Justin.
  
          <rdar://problem/4221384> Denver Regression: stickies widget crashed on 8F15 when pasting text
  
          Test cases added:  None.  Problem triggered by simple paste, which lots of the
          editing tests already do, but also required particular memory layout/cleanup state, which
          is not specifiable in our tests.
  
          * khtml/editing/markup.cpp:
          (khtml::createFragmentFromText):
          Ref the new paragraph element right away, rather than allocating more memory first.
  
  Revision  Changes    Path
  1.4616    +14 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.4615
  retrieving revision 1.4616
  diff -u -r1.4615 -r1.4616
  --- ChangeLog	22 Aug 2005 18:53:25 -0000	1.4615
  +++ ChangeLog	22 Aug 2005 20:24:32 -0000	1.4616
  @@ -1,3 +1,17 @@
  +2005-08-22  David Harrison  <harrison at apple.com>
  +
  +        Reviewed by Justin.
  +
  +        <rdar://problem/4221384> Denver Regression: stickies widget crashed on 8F15 when pasting text
  +
  +        Test cases added:  None.  Problem triggered by simple paste, which lots of the
  +        editing tests already do, but also required particular memory layout/cleanup state, which
  +        is not specifiable in our tests.
  +
  +        * khtml/editing/markup.cpp:
  +        (khtml::createFragmentFromText):
  +        Ref the new paragraph element right away, rather than allocating more memory first.
  +
   2005-08-22  Eric Seidel  <eseidel at apple.com>
           Fix by Tobias Lidskog <tobiaslidskog at mac.com>
   
  
  
  
  1.29      +1 -1      WebCore/khtml/editing/markup.cpp
  
  Index: markup.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/editing/markup.cpp,v
  retrieving revision 1.28
  retrieving revision 1.29
  diff -u -r1.28 -r1.29
  --- markup.cpp	30 Jul 2005 02:33:14 -0000	1.28
  +++ markup.cpp	22 Aug 2005 20:24:39 -0000	1.29
  @@ -594,8 +594,8 @@
                   element->setAttribute(classAttr, AppleInterchangeNewline);            
               } else {
                   element = createDefaultParagraphElement(document);
  -                createParagraphContentsFromString(document, element, s);
                   element->ref();
  +                createParagraphContentsFromString(document, element, s);
               }
               fragment->appendChild(element, exceptionCode);
               ASSERT(exceptionCode == 0);