[webkit-changes] cvs commit: WebKit/WebView.subproj WebView.h WebView.m WebViewPrivate.h

[Geoffrey]

ggaren      05/08/22 18:22:17

  Modified:    .        ChangeLog
               WebView.subproj WebView.h WebView.m WebViewPrivate.h
  Log:
          - fixed <rdar://problem/4227011> Debugger SPI should be removed from WebView.h API
  
          Reviewed by mjs and adele.
  
          Cut and pasted debugging SPI from WebView to WebView(WebPendingPublic)
  
          * WebView.subproj/WebView.h:
          * WebView.subproj/WebView.m:
          (-[WebView setScriptDebugDelegate:]):
          (-[WebView scriptDebugDelegate]):
          * WebView.subproj/WebViewPrivate.h:
  
  Revision  Changes    Path
  1.3301    +14 -0     WebKit/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebKit/ChangeLog,v
  retrieving revision 1.3300
  retrieving revision 1.3301
  diff -u -r1.3300 -r1.3301
  --- ChangeLog	20 Aug 2005 16:27:36 -0000	1.3300
  +++ ChangeLog	23 Aug 2005 01:22:13 -0000	1.3301
  @@ -1,3 +1,17 @@
  +2005-08-22  Geoffrey Garen  <ggaren at apple.com>
  +
  +        - fixed <rdar://problem/4227011> Debugger SPI should be removed from WebView.h API
  +        
  +        Reviewed by mjs and adele.
  +
  +        Cut and pasted debugging SPI from WebView to WebView(WebPendingPublic)
  +        
  +        * WebView.subproj/WebView.h:
  +        * WebView.subproj/WebView.m:
  +        (-[WebView setScriptDebugDelegate:]):
  +        (-[WebView scriptDebugDelegate]):
  +        * WebView.subproj/WebViewPrivate.h:
  +
   2005-08-20  John Sullivan  <sullivan at apple.com>
   
           Reviewed by Darin Adler.
  
  
  
  1.161     +0 -14     WebKit/WebView.subproj/WebView.h
  
  Index: WebView.h
  ===================================================================
  RCS file: /cvs/root/WebKit/WebView.subproj/WebView.h,v
  retrieving revision 1.160
  retrieving revision 1.161
  diff -u -r1.160 -r1.161
  --- WebView.h	30 Jul 2005 03:00:28 -0000	1.160
  +++ WebView.h	23 Aug 2005 01:22:16 -0000	1.161
  @@ -249,20 +249,6 @@
   - (id)policyDelegate;
   
   /*!
  -    @method setScriptDebugDelegate:
  -    @abstract Set the WebView's WebScriptDebugDelegate delegate.
  -    @param delegate The WebScriptDebugDelegate to set as the delegate.
  -*/    
  -- (void)setScriptDebugDelegate:(id)delegate;
  -
  -/*!
  -    @method scriptDebugDelegate
  -    @abstract Return the WebView's WebScriptDebugDelegate.
  -    @result The WebView's WebScriptDebugDelegate.
  -*/    
  -- (id)scriptDebugDelegate;
  -
  -/*!
       @method mainFrame
       @abstract Return the top level frame.  
       @discussion Note that even document that are not framesets will have a
  
  
  
  1.304     +12 -12    WebKit/WebView.subproj/WebView.m
  
  Index: WebView.m
  ===================================================================
  RCS file: /cvs/root/WebKit/WebView.subproj/WebView.m,v
  retrieving revision 1.303
  retrieving revision 1.304
  diff -u -r1.303 -r1.304
  --- WebView.m	20 Aug 2005 16:27:39 -0000	1.303
  +++ WebView.m	23 Aug 2005 01:22:16 -0000	1.304
  @@ -1796,18 +1796,6 @@
   {
       return _private->frameLoadDelegate;
   }
  -- (void)setScriptDebugDelegate:delegate
  -{
  -    _private->scriptDebugDelegate = delegate;
  -    [_private->scriptDebugDelegateForwarder release];
  -    _private->scriptDebugDelegateForwarder = nil;
  -}
  -
  -- scriptDebugDelegate
  -{
  -    return _private->scriptDebugDelegate;
  -}
  -
   
   - (WebFrame *)mainFrame
   {
  @@ -2573,6 +2561,18 @@
       [self _performTextSizingSelector:@selector(_makeTextStandardSize:) withObject:sender onTrackingDocs:notAlreadyStandard selForNonTrackingDocs:@selector(_canMakeTextStandardSize) newScaleFactor:1.0];
   }
   
  +- (void)setScriptDebugDelegate:delegate
  +{
  +    _private->scriptDebugDelegate = delegate;
  +    [_private->scriptDebugDelegateForwarder release];
  +    _private->scriptDebugDelegateForwarder = nil;
  +}
  +
  +- scriptDebugDelegate
  +{
  +    return _private->scriptDebugDelegate;
  +}
  +
   @end
   
   @implementation WebView (WebViewPrintingPrivate)
  
  
  
  1.148     +14 -0     WebKit/WebView.subproj/WebViewPrivate.h
  
  Index: WebViewPrivate.h
  ===================================================================
  RCS file: /cvs/root/WebKit/WebView.subproj/WebViewPrivate.h,v
  retrieving revision 1.147
  retrieving revision 1.148
  diff -u -r1.147 -r1.148
  --- WebViewPrivate.h	20 Aug 2005 16:27:39 -0000	1.147
  +++ WebViewPrivate.h	23 Aug 2005 01:22:16 -0000	1.148
  @@ -90,6 +90,20 @@
   // meets these criteria.
   - (WebFrame *)selectedFrame;
   
  +/*!
  + at method setScriptDebugDelegate:
  + at abstract Set the WebView's WebScriptDebugDelegate delegate.
  + at param delegate The WebScriptDebugDelegate to set as the delegate.
  +*/    
  +- (void)setScriptDebugDelegate:(id)delegate;
  +
  +/*!
  + at method scriptDebugDelegate
  + at abstract Return the WebView's WebScriptDebugDelegate.
  + at result The WebView's WebScriptDebugDelegate.
  +*/    
  +- (id)scriptDebugDelegate;
  +
   @end
   
   @interface WebView (WebPrivate)