[webkit-changes] cvs commit: WebKit/WebView.subproj WebHTMLView.m
Adele
adele at opensource.apple.com
Tue Aug 16 18:31:25 PDT 2005
adele 05/08/16 18:31:25
Modified: . Tag: Safari-2-0-branch ChangeLog
WebView.subproj Tag: Safari-2-0-branch WebHTMLView.m
Log:
Merged fix from TOT to Safari-2-0-branch
2005-08-16 Adele Peterson <adele at apple.com>
Reviewed by John.
- fixed <rdar://problem/4210320> URL tooltips should display a URL for elements that submit forms
When the setShowsURLsInToolTips preference is set, we will display a tooltip containing
the form's url when you mouse over a submit button.
* WebView.subproj/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]):
Revision Changes Path
No revision
No revision
1.3118.4.46 +15 -0 WebKit/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/WebKit/ChangeLog,v
retrieving revision 1.3118.4.45
retrieving revision 1.3118.4.46
diff -u -r1.3118.4.45 -r1.3118.4.46
--- ChangeLog 16 Aug 2005 21:25:24 -0000 1.3118.4.45
+++ ChangeLog 17 Aug 2005 01:31:11 -0000 1.3118.4.46
@@ -2,6 +2,21 @@
Merged fix from TOT to Safari-2-0-branch
+ 2005-08-16 Adele Peterson <adele at apple.com>
+
+ Reviewed by John.
+
+ - fixed <rdar://problem/4210320> URL tooltips should display a URL for elements that submit forms
+
+ When the setShowsURLsInToolTips preference is set, we will display a tooltip containing
+ the form's url when you mouse over a submit button.
+
+ * WebView.subproj/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]):
+
+2005-08-16 Adele Peterson <adele at apple.com>
+
+ Merged fix from TOT to Safari-2-0-branch
+
2005-08-15 Darin <darin at apple.com>
Reviewed by Beth.
No revision
No revision
1.437.8.4 +10 -1 WebKit/WebView.subproj/WebHTMLView.m
Index: WebHTMLView.m
===================================================================
RCS file: /cvs/root/WebKit/WebView.subproj/WebHTMLView.m,v
retrieving revision 1.437.8.3
retrieving revision 1.437.8.4
diff -u -r1.437.8.3 -r1.437.8.4
--- WebHTMLView.m 9 Aug 2005 01:44:47 -0000 1.437.8.3
+++ WebHTMLView.m 17 Aug 2005 01:31:23 -0000 1.437.8.4
@@ -1027,7 +1027,16 @@
// Set a tool tip; it won't show up right away but will if the user pauses.
NSString *newToolTip = nil;
if (_private->showsURLsInToolTips) {
- newToolTip = [[element objectForKey:WebCoreElementLinkURLKey] _web_userVisibleString];
+ DOMHTMLElement *domElement = [element objectForKey:WebElementDOMNodeKey];
+ if ([domElement isKindOfClass:[DOMHTMLInputElement class]]) {
+
+ if ([[(DOMHTMLInputElement *) domElement type] isEqualToString:@"submit"]) {
+ newToolTip = [[(DOMHTMLInputElement *) domElement form] action];
+ }
+ }
+ if (newToolTip == nil) {
+ newToolTip = [[element objectForKey:WebCoreElementLinkURLKey] _web_userVisibleString];
+ }
}
if (newToolTip == nil) {
newToolTip = [element objectForKey:WebCoreElementTitleKey];
More information about the webkit-changes
mailing list