[webkit-changes] cvs commit: WebKit/WebView.subproj WebHTMLView.m

[Adele]

adele       05/08/16 18:29:11

  Modified:    .        ChangeLog
               WebView.subproj WebHTMLView.m
  Log:
          Reviewed by John.
  
          - fixed <rdar://problem/4210320> URL tooltips should display a URL for elements that submit forms
  
          When the setShowsURLsInToolTips preference is set, we will display a tooltip containing
          the form's url when you mouse over a submit button.
  
          * WebView.subproj/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]):
  
  Revision  Changes    Path
  1.3293    +11 -0     WebKit/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebKit/ChangeLog,v
  retrieving revision 1.3292
  retrieving revision 1.3293
  diff -u -r1.3292 -r1.3293
  --- ChangeLog	16 Aug 2005 19:03:22 -0000	1.3292
  +++ ChangeLog	17 Aug 2005 01:29:08 -0000	1.3293
  @@ -1,3 +1,14 @@
  +2005-08-16  Adele Peterson  <adele at apple.com>
  +
  +        Reviewed by John.
  +
  +        - fixed <rdar://problem/4210320> URL tooltips should display a URL for elements that submit forms
  +
  +        When the setShowsURLsInToolTips preference is set, we will display a tooltip containing 
  +        the form's url when you mouse over a submit button.
  +
  +        * WebView.subproj/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]):
  +
   2005-08-16  Darin Adler  <darin at apple.com>
   
           Reviewed by Beth Dakin.
  
  
  
  1.465     +10 -1     WebKit/WebView.subproj/WebHTMLView.m
  
  Index: WebHTMLView.m
  ===================================================================
  RCS file: /cvs/root/WebKit/WebView.subproj/WebHTMLView.m,v
  retrieving revision 1.464
  retrieving revision 1.465
  diff -u -r1.464 -r1.465
  --- WebHTMLView.m	16 Aug 2005 19:03:34 -0000	1.464
  +++ WebHTMLView.m	17 Aug 2005 01:29:10 -0000	1.465
  @@ -1024,7 +1024,16 @@
       // Set a tool tip; it won't show up right away but will if the user pauses.
       NSString *newToolTip = nil;
       if (_private->showsURLsInToolTips) {
  -        newToolTip = [[element objectForKey:WebCoreElementLinkURLKey] _web_userVisibleString];
  +        DOMHTMLElement *domElement = [element objectForKey:WebElementDOMNodeKey];
  +        if ([domElement isKindOfClass:[DOMHTMLInputElement class]]) {
  +
  +            if ([[(DOMHTMLInputElement *) domElement type] isEqualToString:@"submit"]) {
  +                newToolTip = [[(DOMHTMLInputElement *) domElement form] action];
  +            }
  +        }
  +        if (newToolTip == nil) {
  +            newToolTip = [[element objectForKey:WebCoreElementLinkURLKey] _web_userVisibleString];
  +        }
       }
       if (newToolTip == nil) {
           newToolTip = [element objectForKey:WebCoreElementTitleKey];