[webkit-changes] cvs commit: WebCore/khtml/html htmlparser.cpp

[Adele]

adele       05/08/04 14:33:47

  Modified:    .        ChangeLog
               khtml/html htmlparser.cpp
  Log:
          Reviewed by John.
  
          - fixed <rdar://problem/4204496> REGRESSION(denver): repro crash in KHTMLParser::finished() downloading attachment at webmail.mac.com
          This regression was introduced by the fix for <rdar://problem/4084029>.  It was just missing a nil check.
  
          * khtml/html/htmlparser.cpp: (KHTMLParser::finished): added nil check for current.
  
  Revision  Changes    Path
  1.4522    +9 -0      WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.4521
  retrieving revision 1.4522
  diff -u -r1.4521 -r1.4522
  --- ChangeLog	4 Aug 2005 20:27:52 -0000	1.4521
  +++ ChangeLog	4 Aug 2005 21:33:43 -0000	1.4522
  @@ -1,3 +1,12 @@
  +2005-08-04  Adele Peterson  <adele at apple.com>
  +
  +        Reviewed by John.
  +
  +        - fixed <rdar://problem/4204496> REGRESSION(denver): repro crash in KHTMLParser::finished() downloading attachment at webmail.mac.com
  +        This regression was introduced by the fix for <rdar://problem/4084029>.  It was just missing a nil check.
  +
  +        * khtml/html/htmlparser.cpp: (KHTMLParser::finished): added nil check for current.
  +
   2005-08-04  Geoffrey Garen  <ggaren at apple.com>
   
           - fixed <rdar://problem/4199495> REGRESSION: Safari Crashes on Window Closing Event
  
  
  
  1.101     +1 -1      WebCore/khtml/html/htmlparser.cpp
  
  Index: htmlparser.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/html/htmlparser.cpp,v
  retrieving revision 1.100
  retrieving revision 1.101
  diff -u -r1.100 -r1.101
  --- htmlparser.cpp	30 Jul 2005 02:33:18 -0000	1.100
  +++ htmlparser.cpp	4 Aug 2005 21:33:47 -0000	1.101
  @@ -1360,7 +1360,7 @@
   void HTMLParser::finished()
   {
       // In the case of a completely empty document, here's the place to create the HTML element.
  -    if (current->isDocumentNode() && current->firstChild() == 0) {
  +    if (current && current->isDocumentNode() && current->firstChild() == 0) {
           insertNode(new HTMLHtmlElementImpl(document));
       }