[webkit-changes] cvs commit: WebCore/khtml/ecma kjs_binding.cpp

[Geoffrey]

ggaren      05/08/04 13:27:57

  Modified:    .        ChangeLog
               khtml/ecma kjs_binding.cpp
  Log:
          - fixed <rdar://problem/4199495> REGRESSION: Safari Crashes on Window Closing Event
  
          Reviewed by darin.
  
          * khtml/ecma/kjs_binding.cpp:
          (KJS::ScriptInterpreter::updateDOMNodeDocument): inserting a node wrapper into a new
          document set now removes the node wrapper from its old document set.
  
  Revision  Changes    Path
  1.4521    +10 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.4520
  retrieving revision 1.4521
  diff -u -r1.4520 -r1.4521
  --- ChangeLog	4 Aug 2005 02:02:14 -0000	1.4520
  +++ ChangeLog	4 Aug 2005 20:27:52 -0000	1.4521
  @@ -1,3 +1,13 @@
  +2005-08-04  Geoffrey Garen  <ggaren at apple.com>
  +
  +        - fixed <rdar://problem/4199495> REGRESSION: Safari Crashes on Window Closing Event
  +
  +        Reviewed by darin.
  +
  +        * khtml/ecma/kjs_binding.cpp:
  +        (KJS::ScriptInterpreter::updateDOMNodeDocument): inserting a node wrapper into a new
  +        document set now removes the node wrapper from its old document set.
  +
   2005-08-03  Vicki Murley  <vicki at apple.com>
   
           Reviewed by Beth and Hyatt.
  
  
  
  1.35      +5 -3      WebCore/khtml/ecma/kjs_binding.cpp
  
  Index: kjs_binding.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/ecma/kjs_binding.cpp,v
  retrieving revision 1.34
  retrieving revision 1.35
  diff -u -r1.34 -r1.35
  --- kjs_binding.cpp	19 Jul 2005 19:52:48 -0000	1.34
  +++ kjs_binding.cpp	4 Aug 2005 20:27:57 -0000	1.35
  @@ -162,11 +162,13 @@
     }
   }
   
  -void ScriptInterpreter::updateDOMNodeDocument(NodeImpl *node, DOM::DocumentImpl *oldDoc, DOM::DocumentImpl *newDoc)
  +void ScriptInterpreter::updateDOMNodeDocument(DOM::NodeImpl *node, DOM::DocumentImpl *oldDoc, DOM::DocumentImpl *newDoc)
   {
     DOMNode *cachedObject = getDOMNodeForDocument(oldDoc, node);
  -  if (cachedObject)
  -      putDOMNodeForDocument(newDoc, node, cachedObject);
  +  if (cachedObject) {
  +    putDOMNodeForDocument(newDoc, node, cachedObject);
  +    forgetDOMNodeForDocument(oldDoc, node);
  +  }
   }
   
   bool ScriptInterpreter::wasRunByUserGesture() const