- webkit-efl - lists.webkit.org

Re: [webkit-efl] Need to decide coding style for WebKit2 EFL port.
by JongSeok Yang 08 Aug '12

08 Aug '12

2 1

Using 0 or NULL in public C headers documentation ?
by Dumez, Christophe 17 Jul '12

17 Jul '12

Hi, At the moment, we using not consistent in the usage of NULL or 0 in the documentation of our public C headers. The best practice is not currently documented by: http://trac.webkit.org/wiki/EFLWebKitCodingStyle However, Gyuyoung is telling me there is an "unspoken" rule for WebKit-EFL port that we should use 0. I personally disagree and I think we should *always* use NULL in our public C headers. While 0 is advised for null pointers in C++, it is not for C ( http://lwn.net/Articles/93574/) If you look at the EVAS documentation, it is also using NULL in its documentation, not 0. What do other WebKit EFL developers think? We need to agree first, then document it on the coding style page and patch the code accordingly. For example, /** * Gets the Ewk_Settings of this view. * * @param o the view object to get Ewk_Settings * * @return the Ewk_Settings of this view or @c *NULL* on failure */ EAPI Ewk_Settings *ewk_view_settings_get(const Evas_Object *o); Kr, -- Christophe Dumez Linux Software Engineer, PhD Intel Finland Oy - Open Source Technology Center

4 4

Re: [webkit-efl] Using 0 or NULL in public C headers documentation ?
by Gyuyoung Kim 16 Jul '12

16 Jul '12

Hi, As you may know, there is a little document in WebKit. So, it looks EFL port has one of best documentation among other ports. In my opinion, we decide to follow EFL coding style for public APIs because those are used by EFL application. If NULL is C style and EFL style, I think we can use NULL instead of 0. But, if specific bus only start to use it, I think this can make confusion in other bug. So, if we decide to use NULL for API documentation, I think it is better to change this at once. Gyuyoung. ------- Original Message ------- Sender : Dumez, Christophe<christophe.dumez(a)intel.com> Date : 2012-07-16 15:25 (GMT+09:00) Title : Using 0 or NULL in public C headers documentation ? Hi, At the moment, we using not consistent in the usage of NULL or 0 in the documentation of our public C headers. The best practice is not currently documented by: http://trac.webkit.org/wiki/EFLWebKitCodingStyle However, Gyuyoung is telling me there is an "unspoken" rule for WebKit-EFL port that we should use 0. I personally disagree and I think we should *always* use NULL in our public C headers. While 0 is advised for null pointers in C++, it is not for C (http://lwn.net/Articles/93574/) If you look at the EVAS documentation, it is also using NULL in its documentation, not 0. What do other WebKit EFL developers think? We need to agree first, then document it on the coding style page and patch the code accordingly. For example, /** * Gets the Ewk_Settings of this view. * * @param o the view object to get Ewk_Settings * * @return the Ewk_Settings of this view or @c NULL on failure */ EAPI Ewk_Settings *ewk_view_settings_get(const Evas_Object *o); Kr, -- Christophe Dumez Linux Software Engineer, PhD Intel Finland Oy - Open Source Technology Center

2 1

Need to decide coding style for WebKit2 EFL port.
by Gyuyoung Kim 16 Jul '12

16 Jul '12

1 0

efl library dependency bump
by Gyuyoung Kim 04 Jul '12

04 Jul '12

Hello EFL port folks, I would like to bump efl library dependency because there was crash problem in network information APIs. So, the crash bug was fixed by r73025 in EFL community. http://trac.enlightenment.org/e/changeset/73025 I have seen that some bugs also wanna bump efl library version. But, I need to use latest efl version. Could you check if bug below can support your patches ? Bug 90333 <https://bugs.webkit.org/show_bug.cgi?id=90333> - [EFL] Bump version number of EFL libraries (https://bugs.webkit.org/show_bug.cgi?id=90333) Cheers, Gyuyoung

2 2

Building WebKit2?
by Dominik Röttsches 01 Jun '12

01 Jun '12

Hi all, I am trying to build the WebKit2 flavour of EFL WebKit using: $ Tools/Scripts/build-webkit --efl --debug --cmakearg="-D^CARED_CORE=ON -DENABLE_WEBKIT2=ON" Is that the right approach? Anything else I should be aware of? It currently fails with a CMAKE error that I'm investigating. If it is the right way I would go and document it on the Wiki. Dominik -- Dominik Röttsches<dominik.rottsches(a)intel.com>

5 6

ewk_view settings implementation
by Pozdnyakov, Mikhail 31 May '12

31 May '12

Hello, I am implementing now LayoutTestController::overridePreference method for EFL https://bugs.webkit.org/show_bug.cgi?id=83007. I've noticed that each ewk_view related setting (web preference) is currently present in ewk_view as a separate function (see functions starting with ewk_view_setting_... ) In order to implement LayoutTestController::overridePreference I will need to add more ewk_view_setting_ functions to the ewk_view (as not all the settings are present there). That will affect the existing API and will look quite ugly. Don't you think it would be better to have two common methods (getter and setter) for all the web preferences like : Eina_Bool ewk_view_setting_set(Evas_Object *o, const char* property, const Eina_Value* value ); and Eina_Bool ewk_view_setting_get(const Evas_Object *o, const char* property, Eina_Value* value ); I could do such refactoring within the bug83007. Could you please tell your opinion about my proposal? BR, Mikhail --------------------------------------------------------------------- Intel Finland Oy Registered Address: PL 281, 00181 Helsinki Business Identity Code: 0357606 - 4 Domiciled in Helsinki This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

9 13

64-bit release buildbot is sick.
by Gyuyoung Kim 23 May '12

23 May '12

Hello webkit-efl folks, As I notify to webkit-dev, I have upgraded efl ews and 64-bit release buildbot. However, unfortunately, there are some problems. Though buildbot succeeds to be upgraded to 12.04, I lost root permission. I will do my best to solve this problem. It looks this problem caused by ubuntu upgrading via ssh. I will let you guys know when I fix this problem. I restore EFL EWS first for now. Gyuyoung

2 2

Structuring test_expectations.txt into categories
by Dominik Röttsches 22 May '12

22 May '12

Hi, I have a proposed patch for organising our test_expectations.txt into several categories, similar to the GTK approach. Your feedback on the related bug https://bugs.webkit.org/show_bug.cgi?id=86628 is welcome. // We divide our test_expectations.txt into several categories: // 1. TESTS EXPECTED TO FAIL // Test cases related to features that we don't expect to be activated for EFL since e.g. // * the feature implementation in WebCore is not complete yet // * the feature is not relevant for the EFL port // * the feature is meant to solve a backwards compatibility issue on other platforms // Test cases that don't apply for the EFL platform permanently. // If in doubt, please discuss on webkit-efl mailing list whether a set of test cases // should be moved here. // 2. CRASHES // 3. FLAKY TESTS // 4. FAILING TESTS // * Interim failures that are moved here for further investigation as a result of daily // gardening. They should be analysed quickly and either resolved or moved to 1). // * Remaining failures that are moved here until further investigation after // unskipping a directory or block of tests in the Skipped list. // * Tests that we expect to pass once the respective fix for DRT is available or // a relevant compile time feature can be enabled for EFL. Regards, Dominik -- Dominik Röttsches<dominik.rottsches(a)intel.com>

2 2

Missing dbus-1 package on debug buildbot
by Gyuyoung Kim 17 May '12

17 May '12

Hello Dominik, EFL Debug build bot is sick because of missing dbus-1 package. Could you please install dbus-1 to debug buildbot? "No package 'dbus-1' found" The dbus-1 package is required by Bug 83254. Cheers, Gyuyoung

2 1