Hi, I was looking at a patch (https://bugs.webkit.org/show_bug.cgi?id=57535) in which it uses the OS() macro in some headers (to add a conditional include to define time_t). Unfortunately, when these headers are included from WebKit2 files, the build breaks (on various platforms) because OS() isn't defined. Typically OS() is defined by including config.h but that file doesn't seem to be in the cpp files for WebKit2. What is the proper way of fixing this? - include wtf/Platform.h directly in the header files affected (which seem wrong to me). - include config.h in WebKit2 files (but this appears not to be done). - other? Thanks, dave On Mon, Nov 29, 2010 at 1:20 PM, <laszlo.1.gombos@nokia.com> wrote:
Hi,
I'd like to warm up this old thread. Dependency on "prefix header support" seems to be a problem for ARM compiler (ARMCC/RVCT) builds as well (e.g. Symbian build). I've filed a bug to see if we can eliminate this build system dependency - https://bugs.webkit.org/show_bug.cgi?id=50174.
We're considering posting a patch that explicitly includes the prefix header in all WebKit2 cpp files (just like config.h) - as suggested earlier. Concerns/better suggestions are welcome (before we touch 200+ files).
Thanks, Laszlo
-----Original Message----- From: webkit-dev-bounces@lists.webkit.org [mailto: webkit-dev-bounces@lists.webkit.org] On Behalf Of ext Kenneth Christiansen Sent: Wednesday, July 07, 2010 2:36 PM To: Sam Weinig Cc: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] WebKit2 build system
Currently it seems that at least icecc does not. Also, qmake which is the build system for the Qt port does not support prefix headers directly and we thus have to emulate it using the precompiled header support.
Kenneth
On Wed, Jul 7, 2010 at 2:27 PM, Sam Weinig <sam.weinig@gmail.com> wrote:
It should not be necessary to use WebKitPrefix.h as a precompiled header, it is only necessary for it to be used a prefix header. Does discc also not support prefix headers?
webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev