Hi,<div>I was looking at a patch (<a href="https://bugs.webkit.org/show_bug.cgi?id=57535">https://bugs.webkit.org/show_bug.cgi?id=57535</a>) in which it uses the OS() macro in some headers (to add a conditional include to define time_t).</div>
<div><br></div><div>Unfortunately, when these headers are included from WebKit2 files, the build breaks (on various platforms) because OS() isn&#39;t defined. Typically OS() is defined by including config.h but that file doesn&#39;t seem to be in the cpp files for WebKit2.</div>
<div><br></div><div>What is the proper way of fixing this?</div><div><ul><li>include wtf/Platform.h directly in the header files affected (which seem wrong to me).</li><li>include config.h in WebKit2 files (but this appears not to be done).</li>
<li>other?</li></ul></div><div><br></div><div>Thanks,</div><div>dave</div><div><br></div><div><br><div class="gmail_quote">On Mon, Nov 29, 2010 at 1:20 PM,  <span dir="ltr">&lt;<a href="mailto:laszlo.1.gombos@nokia.com">laszlo.1.gombos@nokia.com</a>&gt;</span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Hi,<br>
<br>
I&#39;d like to warm up this old thread. Dependency on &quot;prefix header support&quot; seems to be a problem for ARM compiler (ARMCC/RVCT) builds as well (e.g. Symbian build). I&#39;ve filed a bug to see if we can eliminate this build system dependency - <a href="https://bugs.webkit.org/show_bug.cgi?id=50174" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=50174</a>.<br>

<br>
We&#39;re considering posting a patch that explicitly includes the prefix header in all WebKit2 cpp files (just like config.h) - as suggested earlier. Concerns/better suggestions are welcome (before we touch 200+ files).<br>

<br>
Thanks,<br>
  Laszlo<br>
<div><div></div><div class="h5"><br>
-----Original Message-----<br>
From: <a href="mailto:webkit-dev-bounces@lists.webkit.org">webkit-dev-bounces@lists.webkit.org</a> [mailto:<a href="mailto:webkit-dev-bounces@lists.webkit.org">webkit-dev-bounces@lists.webkit.org</a>] On Behalf Of ext Kenneth Christiansen<br>

Sent: Wednesday, July 07, 2010 2:36 PM<br>
To: Sam Weinig<br>
Cc: <a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
Subject: Re: [webkit-dev] WebKit2 build system<br>
<br>
Currently it seems that at least icecc does not. Also, qmake which is<br>
the build system for the Qt port does not support prefix headers<br>
directly and we thus have to emulate it using the precompiled header<br>
support.<br>
<br>
Kenneth<br>
<br>
On Wed, Jul 7, 2010 at 2:27 PM, Sam Weinig &lt;<a href="mailto:sam.weinig@gmail.com">sam.weinig@gmail.com</a>&gt; wrote:<br>
<br>
&gt; It should not be necessary to use WebKitPrefix.h as a precompiled header, it<br>
&gt; is only necessary for it to be used a prefix header.  Does discc also not<br>
&gt; support prefix headers?<br>
_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
<a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
<a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
</div></div></blockquote></div><br></div>