September 2010 - webkit-dev - lists.webkit.org

Re: [webkit-dev] Script programming language: Perl, Python, or Ruby?
by Ryosuke Niwa 02 Sep '10

02 Sep '10

Hi, On Tue, Aug 31, 2010 at 7:56 AM, TAMURA, Kent <tkent(a)chromium.org> wrote: > Do we have any recommendation of programming language for scripts such as > WebKitTools/Scripts? > It seems new scripts are written by Python and Ruby code is very rare. > > Is it reasonable to port a Ruby script to Python? > I tried to port PrettyPatch.rb to Python in > https://bugs.webkit.org/show_bug.cgi?id=43617 in order to remove Ruby > dependency for many developers and buildbots. However bdash objected it. > Why Ruby to Python? There are also Perl scripts in WebKitTools/Scripts. Could you explain the benefits of converting Ruby scripts to Python? I agree that having to install Ruby, Python, and Perl is a burden for many Windows developers but most of us use Mac / Linux for WebKit development anyways. - Ryosuke

1 0

FrameLoader forwarding calls to FrameLoaderClient
by Nate Chapin 01 Sep '10

01 Sep '10

In looking at ways to decrease the agony associated with FrameLoader, I've noticed that there are a whole of 1-line functions on FrameLoader that just call a similarly named function on FrameLoaderClient without accessing any member variables other than m_client. On the one hand, removing these forwarding functions could move a lot of noise out of FrameLoader. On the other hand, doing so would add another dereference at the callsite and increase the number of places we have to include FrameLoaderClient.h. I'm just curious whether this was a conscious design decision (especially since there are also a bunch of functions on FrameLoaderClient that are called directly, rather than having a corresponding function on FrameLoader). Does anyone have insight into the history of this abstraction or strong feelings on it? ~Nate

2 1

Complex and Vector3 classes in WTF?
by Chris Marrin 01 Sep '10

01 Sep '10

I just noticed these classes, added 7 months ago as part of Chris Rogers' audio work. I think it's a mistake to have these in WTF for a few reasons: 1) Complex is just std::complex with a single added function, complexFromMagnitudePhase(), which seems pretty audio specific, so it should go with the audio code 2) Vector3 has a name very similar to Vector, but with completely different functionality. I actually opened wtf/Vector.h thinking I was going to see a 2D Vector class (because I was in that mindset), then I remembered the _other_ meaning of Vector! So I think it's pretty confusing. 3) Vector3 goes along with other classes, like 2D point, matrices and maybe even lines, planes and other geometry related things. Right now we have FloatPoint2D, FloatPoint3D and TransformationMatrix in WebCore/platform/graphics. These should all be together. I think we should move Complex.h over to live with the rest of the Chris' audio code. Vector3 is a more complex ( ! ) issue. Should we move all the geometry related classes to WTF? If we did I think that should include all the Rect and Box classes as well. Or should we get rid of Vector3, added the functionality it needs to FloatPoint3D and use that? Ken Russell already has plans to do add the functions to FloatPoint3D, so I would vote for that. There's one other problem. Vector3 uses doubles, while FloatPoint3D uses floats. Chris, do you need doubles for your use, or would floats suffice? What do others think? ----- ~Chris cmarrin(a)apple.com

6 20

Problems to build WebKit on Windows
by Diego Gonzalez 01 Sep '10

01 Sep '10

Hi folks, I have some problems to build WebKit ToT on my Window Env. I'm using Visual C++ express 2005. I've followed the steps win: http://webkit.org/building/tools.html After it I ran update-webkit and build-wekit script I got this build output: http://pastebin.com/x99zta73 Some build errors like: InspectorStorageAgent.cpp ..\inspector\InspectorStorageAgent.cpp(64) : error C2039: 'sqlTransactionFailed' : is not a member of 'WebCore::InspectorFrontend' C:\cygwin\home\rodribel\webkit\WebKitBuild\obj\WebCore\DerivedSources\InspectorFrontend.h(17) : see declaration of 'WebCore::InspectorFrontend' ..\inspector\InspectorStorageAgent.cpp(98) : error C2039: 'sqlTransactionSucceeded' : is not a member of 'WebCore::InspectorFrontend' C:\cygwin\home\rodribel\webkit\WebKitBuild\obj\WebCore\DerivedSources\InspectorFrontend.h(17) : see declaration of 'WebCore::InspectorFrontend' and SVGCSSStyleSelector.cpp c:\cygwin\home\rodribel\webkit\webcore\css\CSSPrimitiveValueMappings.h(2217) : error C2065: 'CSSValueButt' : undeclared identifier c:\cygwin\home\rodribel\webkit\webcore\css\CSSPrimitiveValueMappings.h(2231) : error C2051: case expression not constant c:\cygwin\home\rodribel\webkit\webcore\css\CSSPrimitiveValueMappings.h(2249) : error C2065: 'CSSValueMiter' : undeclared identifier c:\cygwin\home\rodribel\webkit\webcore\css\CSSPrimitiveValueMappings.h(2255) : error C2065: 'CSSValueBevel' : undeclared identifier c:\cygwin\home\rodribel\webkit\webcore\css\CSSPrimitiveValueMappings.h(2263) : error C2051: case expression not constant c:\cygwin\home\rodribel\webkit\webcore\css\CSSPrimitiveValueMappings.h(2267) : error C2051: case expression not constant c:\cygwin\home\rodribel\webkit\webcore\css\CSSPrimitiveValueMappings.h(2281) : error C2065: 'CSSValueNonzero' : undeclared identifier c:\cygwin\home\rodribel\webkit\webcore\css\CSSPrimitiveValueMappings.h(2284) : error C2065: 'CSSValueEvenodd' : undeclared identifier seems to be related with features disabled (e.g. database, svg) but these featrues were not disabled for the build. As I do not have experience with these Windows build tools, I wonder if someone could give me some directions to get this build ok. Thanks, Diego

4 5