September 2010 - webkit-dev - lists.webkit.org

Re: [webkit-dev] Blob changes to SecurityOrigin.cpp
by Adam Barth 03 Sep '10

03 Sep '10

On Fri, Sep 3, 2010 at 3:19 PM, Jian Li <jianli(a)google.com> wrote: > Some parts of changes are due to the File API work I have worked on. > On Fri, Sep 3, 2010 at 2:50 PM, Adam Barth <abarth(a)webkit.org> wrote: >> >> I was looking at SecurityOrigin.cpp today and I saw a bunch of code >> relating to Blob URLs. I don't really understand why this code is >> correct. Would someone be willing to explain it to me? >> >> Some specific questions: >> >> 1) Why do blob URLs get exception from the unique origin check? How >> does that interact with the HTML5 sandboxing model? > > The origin of blob URL is said to be the origin of the page under which the > blob URL is created. It is encoded as part of the blob URL: > blob:encoded_origin/id. We're not ignoring any security origin checks. > Instead, we need to pull the encoded origin out of the blob URL and use it > as the base for the origin check. > > The reason that we skip the unique origin check here is to allow a local > running worker script to be able to access a blob URL. Do we want to > disallow this case? The access rights of locally running content are controlled by a WebCore::Setting. Currently, Chrome sets that setting to the most restrictive value to mitigate the harm a downloaded HTML file can cause. It doesn't seem like a good idea to circumvent that security setting. > If there is a security reason for doing this, I can go > ahead to revert this part of change. Thanks. >> 2) Why does SecurityOrigin::canLoad take a document as an argument? >> What are the semantics of this parameter? In particular, why does a >> SecurityOrigin::canLoad ignore |this| when called with a document >> argument on a blob URL? That seems like a very bad idea. > > SecurityOrigin::canLoad is a static method. Does it have |this| to use? Oh, that's right. SecurityOrigin::canLoad is junk we moved over from FrameLoader. We need to make it an instance method since all the callers have a document anyway. I don't quite understand what this code is trying to do: bool SecurityOrigin::canLoad(const KURL& url, const String& referrer, Document* document) { #if ENABLE(BLOB) if (url.protocolIs("blob") && document) { SecurityOrigin* documentOrigin = document->securityOrigin(); RefPtr<SecurityOrigin> targetOrigin = SecurityOrigin::create(url); return documentOrigin->isSameSchemeHostPort(targetOrigin.get()); } #endif Why should canLoad care about isSameSchemeHostPort? In the past, canLoad's job was to stop web sites from loading content from your local file system (e.g., in frames or as images). Adam

2 5

Blob changes to SecurityOrigin.cpp
by Adam Barth 03 Sep '10

03 Sep '10

I was looking at SecurityOrigin.cpp today and I saw a bunch of code relating to Blob URLs. I don't really understand why this code is correct. Would someone be willing to explain it to me? Some specific questions: 1) Why do blob URLs get exception from the unique origin check? How does that interact with the HTML5 sandboxing model? 2) Why does SecurityOrigin::canLoad take a document as an argument? What are the semantics of this parameter? In particular, why does a SecurityOrigin::canLoad ignore |this| when called with a document argument on a blob URL? That seems like a very bad idea. In general, I'd prefer if folks checked with Sam or me before adding loopholes in SecurityOrigin. Although the class might appear simple, it's quite subtle. Adam

2 1

Re: [webkit-dev] W3C Proposal: User Interface Independence for Accessible Rich Internet Applications
by James Craig 03 Sep '10

03 Sep '10

On Sep 3, 2010, at 9:35 AM, Tony Chang wrote: > I'm curious what elements the UIRequestEvents apply to. Does it fire at the document level or does it fire for specific elements like textareas? Good question. I'd say probably document.activeElement if applicable, or otherwise document.bodyElement. For example, Mobile Safari usually doesn't have an activeElement (unless a form field is focused), but Safari with VoiceOver running always has a non-null activeElement. The event would bubble from there, and eventually fire on the body unless bubbling was stopped by a listener assigned lower in the DOM tree. I assume most web apps would want to just register a delegate listener on the body.

1 0

GTK Skiplist
by Jeremy Orlow 03 Sep '10

03 Sep '10

Recently in a code review for IndexedDB, I was told that I should be adding every test individually to GTK's skip list. The reason cited was this comment at the top "# Also, no grouping should occur. Every test for itself." For features like IndexedDB which are not turned on by a port, is it still expected that I should be adding each and every test to the GTK skip list? If so, why? /storage/indexeddb has been in the skip list for some time and seems to work fine, at least from a technical standpoint. Thanks, Jeremy

5 6

Bug 15256 - Bounty for fix
by Frederico Caldeira Knabben 03 Sep '10

03 Sep '10

Hi all, We've been living for years with a pretty bad issue in CKEditor, exclusive to WebKit based browsers: http://dev.ckeditor.com/ticket/1272 It's caused by the following: https://bugs.webkit.org/show_bug.cgi?id=15256 As some of you may now, I've contacted you guys a few times in the past, trying to have this issued fixed. We had no results out of it, unfortunately. This issue has already brought problems for us and disappointment to our users for too long. As we're not able to code a fix, we thought that maybe some money reward could help. We, together with Lee McDermott, are allocating $300 for the developer(s) who will make a fix for it reach a public Safari/Chrome release. I know you'll not become rich with it, but it looked like a nice way to say thank you for the effort, to make extra money, and to first of all contribute to make WebKit better. Who's willing to step in? Please reply to the list as well, because this is a task to be executed under the core team observation, respecting the WebKit rules. Thanks, Fred -- Frederico Caldeira Knabben CEO, CKSource ---- http://cksource.com

1 0

How to specify files to be copied to WebKitBuild/Debug/WebCore.framework/PrivateHeaders/ ?
by Yuzo Fujishima 03 Sep '10

03 Sep '10

Hi, webkit developers, I locally changed WebCore/platform/graphics/FontFallbackList.h such that it includes SegmentedFontData.h in the same directory [1]. Since then build-webkit complains that SegmentedFontData.h cannot be found [2]. Actually I don't see SegmentedFontData.h in WebKitBuild/.../PrivateHeaders/ directory. How can I specify that SegmentedFontData.h must be copied to the directory? Yuzo [1] diff --git a/WebCore/platform/graphics/FontFallbackList.h b/WebCore/platform/graphics/FontFallbackList.h index a0b94dd..d3409f9 100644 --- a/WebCore/platform/graphics/FontFallbackList.h +++ b/WebCore/platform/graphics/FontFallbackList.h @@ -22,6 +22,7 @@ #define FontFallbackList_h #include "FontSelector.h" +#include "SegmentedFontData.h" #include "SimpleFontData.h" #include <wtf/Forward.h> ... [2] ... CompileC <WebKitSrc>/WebKitBuild/WebKit.build/Debug/WebKit.build/Objects-normal/x86_64/WebRenderNode.o mac/WebView/WebRenderNode.mm normal x86_64 objective-c++ com.apple.compilers.gcc.4_2 cd <WebKitSrc>/WebKit /Developer/usr/bin/gcc-4.2 -x objective-c++ -arch x86_64 -fmessage-length=0 -pipe -Wno-trigraphs -fno-exceptions -fno-rtti -fpascal-strings -fasm-blocks -O0 -Werror -Wmissing-prototypes -Wnon-virtual-dtor -Wnewline-eof -DDISABLE_THREAD_CHECK -DENABLE_WEBKIT_UNSET_DYLD_FRAMEWORK_PATH -DENABLE_3D_CANVAS -DENABLE_3D_RENDERING -DENABLE_BLOB -DENABLE_CHANNEL_MESSAGING -DENABLE_CLIENT_BASED_GEOLOCATION -DENABLE_DATABASE -DENABLE_DATALIST -DENABLE_DOM_STORAGE -DENABLE_EVENTSOURCE -DENABLE_FILTERS -DENABLE_FULLSCREEN_API -DENABLE_GEOLOCATION -DENABLE_ICONDATABASE -DENABLE_JAVASCRIPT_DEBUGGER -DENABLE_MATHML -DENABLE_METER_TAG -DENABLE_OFFLINE_WEB_APPLICATIONS -DENABLE_PROGRESS_TAG -DENABLE_RUBY -DENABLE_SANDBOX -DENABLE_SHARED_WORKERS -DENABLE_SVG -DENABLE_SVG_ANIMATION -DENABLE_SVG_AS_IMAGE -DENABLE_SVG_DOM_OBJC_BINDINGS -DENABLE_SVG_FONTS -DENABLE_SVG_FOREIGN_OBJECT -DENABLE_SVG_USE -DENABLE_VIDEO -DENABLE_WEB_SOCKETS -DENABLE_WORKERS -DENABLE_XPATH -DENABLE_XSLT -DFRAMEWORK_NAME=WebKit -DWEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST -fobjc-gc -fvisibility-inlines-hidden -fno-threadsafe-statics -mmacosx-version-min=10.6 -gdwarf-2 -I<WebKitSrc>/WebKitBuild/WebKit.build/Debug/WebKit.build/WebKit.hmap -Wall -Wextra -Wchar-subscripts -Wextra-tokens -Wformat-security -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wno-unused-parameter -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wcast-align -F<WebKitSrc>/WebKitBuild/Debug -F/System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks -F/System/Library/Frameworks/ApplicationServices.framework/Frameworks -F/System/Library/Frameworks/Carbon.framework/Frameworks -F/System/Library/Frameworks/Quartz.framework/Frameworks -F/System/Library/PrivateFrameworks -I<WebKitSrc>/WebKitBuild/Debug/include -I<WebKitSrc>/WebKitBuild/Debug/WebCore.framework/PrivateHeaders/ForwardingHeaders -I<WebKitSrc>/WebKitBuild/Debug/WebCore.framework/PrivateHeaders/icu -I<WebKitSrc>/WebKitBuild/Debug/usr/local/include -I<WebKitSrc>/WebKitBuild/Debug/DerivedSources/WebKit -I<WebKitSrc>/WebKitBuild/WebKit.build/Debug/WebKit.build/DerivedSources/x86_64 -I<WebKitSrc>/WebKitBuild/WebKit.build/Debug/WebKit.build/DerivedSources -include /var/folders/++/++-8Jk++6+0++4RjPqRgNE++GZQ/-Caches-/com.apple.Xcode.19031/SharedPrecompiledHeaders/WebKitPrefix-cejasxonupvwgnfamqhxhbfgzugy/WebKitPrefix.h -c <WebKitSrc>/WebKit/mac/WebView/WebRenderNode.mm -o <WebKitSrc>/WebKitBuild/WebKit.build/Debug/WebKit.build/Objects-normal/x86_64/WebRenderNode.o In file included from <WebKitSrc>/WebKitBuild/Debug/WebCore.framework/PrivateHeaders/Font.h:30, from <WebKitSrc>/WebKitBuild/Debug/WebCore.framework/PrivateHeaders/RenderStyle.h:47, from <WebKitSrc>/WebKitBuild/Debug/WebCore.framework/PrivateHeaders/RenderObject.h:36, from <WebKitSrc>/WebKitBuild/Debug/WebCore.framework/PrivateHeaders/RenderText.h:26, from <WebKitSrc>/WebKit/mac/WebView/WebRenderNode.mm:34: <WebKitSrc>/WebKitBuild/Debug/WebCore.framework/PrivateHeaders/FontFallbackList.h:25:31: error: SegmentedFontData.h: No such file or directory ...

3 4

Arena is crufty?
by Chris Marrin 02 Sep '10

02 Sep '10

Ken's PODRedBlackTree patch has made me go back and take a closer look at WebKit's Arena "class". Turns out it's not a class at all, just some structs and macros. That seems very un-WebKit-like to me. Ken's patch also has a PODArena class, which uses Arena in its implementation. Sam suggests that PODRedBlackTree should really go into WTF, which means PODArena and Arena would need to go there as well. It seems like Arena really needs to be brought into the 21st century and made a proper class. Maybe now is the right time to: 1) Make Arena a class 2) Integrate Ken's PODArena functionality into this new Arena class (or maybe just make Ken's PODArena the new Arena class). 3) Move the new Arena class to WTF 4) Put PODRedBlackTree in WTF It looks like RenderArena is currently the only client of Arena.h, so this change shouldn't be too hard. Of course, looking at RenderArena, it's a little odd, too. It is not renderer specific at all. It's just an Arena that recycles freed objects. Maybe we should move that functionality into the new Arena class. But RenderArena is used all over the place, so maybe that's going one step too far down this road? ----- ~Chris cmarrin(a)apple.com

7 20

How to setup WebKit-EFL mailing list
by Rafael Antognolli 02 Sep '10

02 Sep '10

Hello all, Sorry if this is not the right place to ask for this, but I wasn't sure about which mailing list I should send this email to. So, is it possible to setup a mailing list for the EFL port in lists.webkit.org? If yes, how should I proceed to accomplish this? Thank you for your attention, -- Rafael Antognolli ProFUSION embedded systems http://profusion.mobi

1 0

contribute SH4 JIT
by thouraya andolsi 02 Sep '10

02 Sep '10

Hello, I would like to contribute the SH4 JIT for JavaScriptCore. I submitted as a first step a patch containing some changes in the build system to support sh4 platform for GDK/Directfb backend to https://bugs.webkit.org/show_bug.cgi?id=44329. Could you please review it ? Best regards, Thouraya.

2 1

Script programming language: Perl, Python, or Ruby?
by TAMURA, Kent 02 Sep '10

02 Sep '10

Do we have any recommendation of programming language for scripts such as WebKitTools/Scripts? It seems new scripts are written by Python and Ruby code is very rare. Is it reasonable to port a Ruby script to Python? I tried to port PrettyPatch.rb to Python in https://bugs.webkit.org/show_bug.cgi?id=43617 in order to remove Ruby dependency for many developers and buildbots. However bdash objected it. -- TAMURA Kent Software Engineer, Google

9 15