July 2005 - webkit-dev - lists.webkit.org

layout test failures
by Adele Peterson 16 Jul '05

16 Jul '05

Hi all, I'm seeing failures for the following tests: fast/dom/outerText-no-element fast/dynamic/outerHTML-no-element fast/js/array-every fast/js/array-foreach fast/js/array-some fast/js/toString-stack-overflow All of the diffs are very similar to: -RangeError : Maximum call stack size exceeded. +RangeError: Maximum call stack size exceeded. Looks like we just need to update a few expected results. Unless anyone objects, I'll do that later tonight. -Adele

3 3

KWQ Graphics implementation cross-platform suggestion
by Justin Haygood 14 Jul '05

14 Jul '05

I think maybe making use of the Cairo library might make a cross-platform implementation for the graphics component of the KWQ library. I believe the licenses are compatible enough, Cairo is LGPL.

4 4

SVG Checkout Changes
by Eric Seidel 12 Jul '05

12 Jul '05

In order to make it easier on those WebKit hackers not involved with WebCore+SVG, I've moved all the necessary files out of the WebCore directory. What this means: 1. ALL developers with a current copy of WebCore/ will need to remove the directories kdom, kcanvas and ksvg2 from WebCore, otherwise your next update-webkit will fail. 2. Those now looking to use WebCore+SVG, should run the WebKitTools/ checkout-svg script. That will checkout SVGSupport and put symlinks in the right places in WebCore. If you have any questions, drop me a line, or find me on #webkit. -eric

1 0

SVG directories moving
by Eric Seidel 12 Jul '05

12 Jul '05

Hi all- In order to make cvs-create-patch faster (and in-xcode file search results smaller) for those developers not interested in SVG development, I will be moving the SVG directories into their own top- level module WebCore+SVG. This will be along-side with the addition of a checkout-svg script for checking out the pieces of this module into the proper place (WebCore/ksvg2, WebCore/kdom, WebCore/kcanvas). If you are not currently doing any SVG related development, this will not affect you. If you are doing SVG related development, you will have to run the checkout-svg script in order to get a new (moved) copy of the SVG CVS tree. Thanks. -eric p.s. In addition to these changes, I will also be introducing a number of small *temporary* SPI additions to WebCore+SVG, to allow the use of several SVG test programs I have put together. I plan to make these SPI additions tonight, after the cvs re-org, as well as (if I have time) commit my various test programs into CVS so that you all can start actually displaying SVGs on your own machines.

1 0

WebKit bug in Dashboard widget?
by Ben Kazez 11 Jul '05

11 Jul '05

Hi everyone, I'm working on a Dashboard widget with a multi-threaded Cocoa plugin. The plugin seems to be working just fine, but I'm getting an occasional (frequent but inconsistent) crash that appears to indicate a bug in WebKit: ====================================================== Exception: EXC_BAD_ACCESS (0x0001) Codes: KERN_PROTECTION_FAILURE (0x0002) at 0x00000018 Thread 0 Crashed: 0 com.apple.WebCore 0x95c4a734 khtml::inlineWidth (khtml::RenderObject*, bool, bool) + 152 1 com.apple.WebCore 0x95c48b98 khtml::RenderBlock::findNextLineBreak(khtml::BidiIterator&, khtml::BidiState&) + 3548 2 com.apple.WebCore 0x95c46dbc khtml::RenderBlock::layoutInlineChildren(bool) + 1980 3 com.apple.WebCore 0x95c435d4 khtml::RenderBlock::layoutBlock(bool) + 692 4 com.apple.WebCore 0x95c4a49c khtml::RenderBlock::layoutPositionedObjects(bool) + 172 5 com.apple.WebCore 0x95c43930 khtml::RenderBlock::layoutBlock(bool) + 1552 6 com.apple.WebCore 0x95c4409c khtml::RenderBlock::layoutBlockChildren(bool) + 696 7 com.apple.WebCore 0x95c435ec khtml::RenderBlock::layoutBlock(bool) + 716 8 com.apple.WebCore 0x95c40524 khtml::RenderCanvas::layout() + 252 9 com.apple.WebCore 0x95c3fe08 KHTMLView::layout() + 792 10 com.apple.WebCore 0x95c52518 -[WebCoreBridge forceLayoutAdjustingViewSize:] + 56 11 com.apple.WebKit 0x959ce11c -[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:] + 228 12 com.apple.WebKit 0x959e1328 -[WebHTMLView (WebPrivate) _web_layoutIfNeededRecursive] + 36 13 com.apple.WebKit 0x959cb8c0 -[WebHTMLView (WebPrivate) _propagateDirtyRectsToOpaqueAncestors] + 72 ... ====================================================== The crash is preceded by incorrect width of displayed divs, disappearing elements, or both. Does this seem to you to be a WebKit bug, or could there be a problem with my code? Ben

3 4

layout tests failing
by Maciej Stachowiak 10 Jul '05

10 Jul '05

A number of layout tests are failing. Since no reviewers are around I can't land the fix but it is attached to http:// bugzilla.opendarwin.org/show_bug.cgi?id=3940 Cheers, Maciej

2 1

build broken
by Carsten Guenther 10 Jul '05

10 Jul '05

Current ToT does not build: CompileC /Users/carsten/WebKit/WebKitBuild/WebCore.build/Development/WebCore.build/Objects-normal/ppc/htmlparser.o khtml/html/htmlparser.cpp normal ppc c++ com.apple.compilers.gcc.4_0 mkdir /Users/carsten/WebKit/WebKitBuild/WebCore.build/Development/WebCore.build/Objects-normal/ppc cd /Users/carsten/WebKit/WebCore setenv MACOSX_DEPLOYMENT_TARGET 10.3 /usr/bin/gcc-4.0 -x c++ -arch ppc -pipe -Wno-trigraphs -fno-exceptions -fno-rtti -fpascal-strings -fasm-blocks -g -O0 -Werror -Wnon-virtual-dtor -DAPPLE_CHANGES -DKHTML_NO_CPLUSPLUS_DOM -fmessage-length=0 -mtune=G4 -I/Users/carsten/WebKit/WebKitBuild/WebCore.build/Development/WebCore.build/WebCore.hmap -Wall -W -Wcast-align -Wchar-subscripts -Wformat-security -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-format-y2k -Wno-unused-parameter -F/Users/carsten/WebKit/WebKitBuild/Development -F/System/Library/Frameworks/WebKit.framework/Frameworks -I/Users/carsten/WebKit/WebKitBuild/Development/include -IForwardingHeaders -Iicu -I/usr/include/libxslt -I/usr/include/libxml2 -I/Users/carsten/WebKit/WebKitBuild/WebCore.build/Development/WebCore.build/DerivedSources -include /Library/Caches/com.apple.Xcode.501/SharedPrecompiledHeaders/WebCorePrefix-bfvsjhijwutcwxcqdyjlycnaspbo/WebCorePrefix.h -c /Users/carsten/WebKit/WebCore/khtml/html/htmlparser.cpp -o /Users/carsten/WebKit/WebKitBuild/WebCore.build/Development/WebCore.build/Objects-normal/ppc/htmlparser.o /Users/carsten/WebKit/WebCore/khtml/misc/hashtraits.h: In instantiation of 'khtml::HashTraits<bool (HTMLParser::*)(khtml::Token*, DOM::NodeImpl*&)>': /Users/carsten/WebKit/WebCore/khtml/misc/hashmap.h:155: instantiated from 'Mapped khtml::HashMap<Key, Mapped, HashFunctions, KeyTraits, MappedTraits>::get(const Key&) const [with Key = void*, Mapped = bool (HTMLParser::*)(khtml::Token*, DOM::NodeImpl*&), HashFunctions = khtml::DefaultHash<void*>, KeyTraits = khtml::HashTraits<void*>, MappedTraits = khtml::HashTraits<bool (HTMLParser::*)(khtml::Token*, DOM::NodeImpl*&)>]' /Users/carsten/WebKit/WebCore/khtml/misc/pointerhash.h:159: instantiated from 'Mapped khtml::HashMap<P*, Mapped, khtml::PointerHash<P*>, khtml::HashTraits<P*>, khtml::HashTraits<Second> >::get(P* const&) const [with P = DOM::DOMStringImpl, Mapped = bool (HTMLParser::*)(khtml::Token*, DOM::NodeImpl*&)]' /Users/carsten/WebKit/WebCore/khtml/html/htmlparser.cpp:809: instantiated from here /Users/carsten/WebKit/WebCore/khtml/misc/hashtraits.h:36: error: '_M_type' is not a member of 'std::__is_integer<bool (HTMLParser::*)(khtml::Token*, DOM::NodeImpl*&)>' ** BUILD FAILED **

4 5

2005-07-8 test cases missing?
by Hanspeter Schaub 09 Jul '05

09 Jul '05

Howdy, I did an update this morning (July 9 2005) and looked at the change logs. There are supposed to be layout-tests/fast/css/MarqueeLayoutTest.html layout-tests/fast/text/international/bidi-fallback-font-weight.html but they appear to be missing? Anybody else see this? thanks, HP --------------------------------------------------------------- Hanspeter Schaub Phone: (540) 763-8370 Email: HanspeterSchaub(a)mac.com Web: http://homepage.mac.com/hanspeterschaub

3 2

Experimental SVG support
by Eric Seidel 09 Jul '05

09 Jul '05

I'm proud to announce the introduction of experimental SVG support into WebCore. Over the last few months I ported KDE's new DOM architecture "KDOM" as well as their Scaleable Vector Graphics (SVG) implementation "KSVG2" and render tree library "KCanvas" to WebCore. Working with the Safari team over the last few weeks, we have now integrated these changes into the WebCore cvs tree to allow the investigation of further integration of SVG support into Safari. The SVG page on WebKit (http://webkit.opendarwin.org/projects/svg) contains more information regarding the status of the project including build instructions, using SVG, etc. There is a lot left to be done, but here's hoping for a bright SVG future! -eric Disclaimer: Let me emphasize that at this time there is NO SVG support in Safari itself, nor has Apple (or myself) made any commitment to ship SVG support in Safari, now or in the future. However, with your help (the open source community) I would very much like to see full SVG integration in WebKit in the future.

2 1

Re: [webkit-dev] Random Failures
by Eric Seidel 07 Jul '05

07 Jul '05

Thanks Mark. One next step is to try running under libgmalloc. That should catch whatever this is every time on the same test. I'll try that when I get into work. -eric On Jul 7, 2005, at 5:59 AM, Mark Rowe wrote: > > On 8/07/2005, at 00:41 , Mark Rowe wrote: > > >> I've spent the last two hours trying to track down which change >> causes the test failures + DumpRenderTree crash. As was >> mentioned, rolling out the patch for bugs #3882 and #3829 does not >> resolve the issue. Rolling out #3826 and #3674 individually >> didn't help either. It seemed that removing *both* stopped the >> crashing but that may have just been luck as the crashes are >> intermittent at best. I'm retesting this scenario now. >> > > It seems I was just lucky... As far as I can tell none of the four > patches have any relation to the failing test + crash. I'm not > sure which other changes have been checked in recently that I could > check, so I'll leave that up to someone else. > > Regards, > > Mark Rowe > <http://bdash.net.nz/> >

1 2