June 2005 - webkit-dev - lists.webkit.org

Xcode editor settings
by David Lázaro Saz 10 Jun '05

10 Jun '05

Hi there, I'm wondering how did you (the original WebKit developers) recommend to configure Xcode (I'm using 2.1) in order to edit WebKit files. Right now it's very strange for me because there is something in the coding style that really doesn't reflect my own. Lines are wider than wide, for example, as message sends are almost never broken in multiple lines. Maybe is that I have to get used to it, or that my PowerBook 15 screen is smaller than the ones in which it was developed, don't know. So I think it would help us knowing what layout and preferences are you using or recommending in order to adapt my environment. I also think that that "never break a message" should be in the coding guidelines if it is the preferred form. Cheers, David.

2 4

PCRE
by Justin Haygood 10 Jun '05

10 Jun '05

I want to make a suggestion to Apple: can ya'll update the PCRE in CVS HEAD to PCRE 5.0 (6.0 is too complex, and 5.0 has a fully working Win32 implementation)? This would make it easier to keep my local copy of WebKit in sync with CVS HEAD.. not having to use different versions of a library ya'll use just to compile :-D. --Justin Haygood

2 1

Win32 port / KWQ
by Patrick Forget 10 Jun '05

10 Jun '05

Hello everyone, A year ago I have try to port WebCore (1.25) to the Windows platform. For this, I took the file in /kwq and try to convert them to C++ using native windows call for the widget. However, I have gave up a few month later because I did find the job way too difficult (and also lost some interest on this project). If I recall, most of Objective-C files were converted to C++ (even if there is no implementation). I do have a working implementation (at least partial) for KWQWidget, KWQButton, KWQPainter using the Win32 api. I will not have any time on myself to work on project for the next month (vacations and some other stuff are more important). But still, it may be useful to give the code so at least I didn't work for nothing, and it may also spare some time on other people by providing a starting point. Hope I can help Patrick

1 0

Magnifying glass on downloads window does not select file in Finder while downloading
by Paulo Jorge Rodrigues Góis 10 Jun '05

10 Jun '05

1. In the Download window of Safari the little magnifying glass next to a listed downloading file, does not highlight the corresponding file on Finder wille the download is still in progress. 2. Also some internet-enabled image files don't get unwrapped out of the Safari .download package container after the download has finished. This occours when the Post-processing option "Don't move Internet-enabled images to Trash" (accessible through Disk Utility preferences) is checked. Paulo Jorge Rodrigues Góis pjrgois(a)oniduo.pt

2 1

build-related improvements I'm thinking of
by Darin Adler 10 Jun '05

10 Jun '05

Here are a few things I'd like to improve that are build-related: 1) The run-webkit-tests script doesn't work yet for Xcode 2.1 users. Should be easy to fix and I want to do that. 2) I want to figure out why many of the Mozilla JavaScript tests are failing for people other than the Safari team. For us, the expected and actual results currently match on TOT, but for most others there are many unexpected successes and many unexpected failures. Need to fix that. 3) I don't like the way you have to pass the build style into every script now -- if you want to use Development build style you have to pass it to every single command, and run-safari has a pretty weak heuristic where it looks in multiple directories that could lead to running the wrong Safari binary. I want to put a "default build style" file inside the product build directory, have a script to set that, and have all the other scripts obey that unless you explicitly specify Development or Deployment style. Other details: I want the script that changes build styles to clean out the build directories if you are using Xcode 2.0 but not if you are using Xcode 2.1. 4) I want to update the building page <http:// webkit.opendarwin.org/building/build.html> to remove step 1, since setting the build preference for Xcode is no longer necessary. I'm posting this to the list today in case someone has other ideas and wants to stop me or advise me. I wonder if I should put any of these into Bugzilla. -- Darin

1 0

JSCore patch question and wxWebCore
by Kevin Ollivier 10 Jun '05

10 Jun '05

Hi all, First off, I wanted to say I'm really impressed with Apple's commitment to open source. IMHO, the actions you've taken go above and beyond the call of duty and show an openness that few companies are willing to risk. And I think in the end it will pay off big for anyone using WebCore or derivatives. In fact, as the developer of wxWebKitCtrl (a WebKit wrapper for wxMac), open sourcing this will hopefully help me track down a couple positioning bugs that have eluded me thus far. So thank you for doing this! :-) However, I do have more to say than that. :-) Vaclav Slavik (the author of wxWidgets' wxHTML support, among many other things) and I have embarked on a rather ambitious project, which is the development of a wxWidgets implementation of WebCore. I do recall one of the developers saying they'd be open to/interested in a multi-platform WebCore. ;-) We'd also like to develop an ActiveX front end as well, so that apps outside of wxWidgets apps on Windows can take advantage of WebCore. We've been working on it for a couple weeks now and we have setup a SVN repository for it at: http://developer.berlios.de/projects/wxwebcore We've still got a long ways to go, but we've gotten a fair amount of files compiling these past couple weeks (both on Mac and Linux) and hope within a month or so that we can move towards a basic prototype. Related to this project, I had a couple questions for WebKit developers: 1) We have a patch for JSCore 412 that includes some simple compilation fixes like added headers and such to get it to compile on Linux. Are you interested in this, and if so, do we just submit it to the WebKit bugzilla? 2) Is the WebKit site and mailing list going to be the primary discussion and project space for WebCore as well now? As WebKit is a superset, I wasn't sure if this was more appropriate here, or if WebCore's discussion forum was a more appropriate place. Anyways, the newly open-sourced WebKit will definitely help us in our implementation, and I hope that our work can be useful to the WebKit development team as well. It will certainly be of great benefit to the wxWidgets project! We welcome any feedback on the project, and will be happy to try and answer any questions you may have. Thanks, Kevin

3 3

JavaScriptCore Conservative Garbage Collector
by Justin Haygood 10 Jun '05

10 Jun '05

I want to know pretty much what the reason behind each of these are, so I can better implement it using another also portable threading library (NSPR): markCurrentThreadConservatively() markOtherThreadConservatively(Thread *thread) What does mark conversatively mean? NSPR doesn't have a way to access the stack objects of each thread, so I'm in a bit of a bind. The NSPR threading library does have pretty much everything else a threading library needs, and is very clean.

3 4

recent KJS_CHECK_EXCEPTION change (needs improvement?)
by Darin Adler 09 Jun '05

09 Jun '05

I was looking at the recent change to KJS_CHECK_EXCEPTION, and I was wondering if it's correct. It looks to me like each level is going to overwrite the source file and line number set by the level below it. So the code needs to change to attach a new source file and line number only if it's not already set on the exception being propagated. What do you think? -- Darin

2 1

debug patch for run-safari
by Mike Solomon 09 Jun '05

09 Jun '05

pretty trivial, but bit me. enjoy. [msolomon]phoenix:~/Projects/WebKitTools/Scripts> cvs diff -u3 run- safari Index: run-safari =================================================================== RCS file: /cvs/root/WebKitTools/Scripts/run-safari,v retrieving revision 1.4 diff -u -3 -r1.4 run-safari --- run-safari 2005/06/08 09:00:52 1.4 +++ run-safari 2005/06/08 18:40:59 @@ -54,6 +54,7 @@ my @testDirs = ( "$productDir", "$productDir/Deployment", "$productDir/Development" ); my $found = 0; for my $testDir (@testDirs) { + next if ($debug && $testDir =~ m/Deployment$/); # Check to see that frameworks are there. print "Looking for frameworks in $testDir ...\n";

2 1

error: WebKitSystemInterface.h: No such file or directory
by Robert Nicholson 09 Jun '05

09 Jun '05

Anybody else get this problem whilst building? CompileC /Users/robert/.build/WebKit.build/WebKit.build/Objects- normal/ppc/WebHistoryItem.o History.subproj/WebHistoryItem.m normal ppc objective-c com.apple.compilers.gcc.4_0 setenv MACOSX_DEPLOYMENT_TARGET 10.3 cd /Users/robert/Programming/Objective-C/WebKit /usr/bin/gcc-4.0 -x objective-c -arch ppc -pipe -Wno-trigraphs - fpascal-strings -fasm-blocks -g -Os -Werror -Wmissing-prototypes - DNDEBUG -DFRAMEWORK_NAME=WebKit -fmessage-length=0 -fobjc-direct- dispatch -fobjc-gc -mtune=G4 -I/Users/robert/.build/WebKit.build/ WebKit.build/WebKit.hmap -Wall -W -Wcast-align -Wchar-subscripts - Wformat-security -Wmissing-format-attribute -Wpointer-arith -Wwrite- strings -Wno-format-y2k -Wno-unused-parameter -F/Users/robert/.build - F/System/Library/Frameworks/WebKit.framework/Frameworks -F/System/ Library/Frameworks/ApplicationServices.framework/Frameworks -F/System/ Library/Frameworks/Carbon.framework/Frameworks -F/System/Library/ PrivateFrameworks -F/Users/robert/.build/WebKit.build/WebKit.build/ DerivedSources -I/Users/robert/.build/include -I/Users/robert/.build/ usr/local/include -Iicu -I/Users/robert/.build/WebKit.build/ WebKit.build/DerivedSources -Wbad-function-cast -Wmissing- declarations -Wnested-externs -include /Users/robert/.build/ WebKit.build/SharedCaches/WebKitPrefix-dchauuscogpubwcnhifqbwhayxnq/ WebKitPrefix.h -c /Users/robert/Programming/Objective-C/WebKit/ History.subproj/WebHistoryItem.m -o /Users/robert/.build/WebKit.build/ WebKit.build/Objects-normal/ppc/WebHistoryItem.o /Users/robert/Programming/Objective-C/WebKit/History.subproj/ WebHistoryItem.m:45:34: error: WebKitSystemInterface.h: No such file or directory

4 6