June 2005 - webkit-dev - lists.webkit.org

Newline translation issue with textareas
by Kevin Ballard 21 Jun '05

21 Jun '05

I'm trying to solve <http://bugzilla.opendarwin.org/show_bug.cgi? id=3401>, which involves writing accessors for the selection on QTextEdit and KWQTextArea. After poking around, I discovered that KWQTextArea translates \r\n sequences (and just plain \r sequences) to \n when returning its text value. This makes a certain amount of sense, because standardizing newlines can be helpful at times, and Firefox also exhibits this behaviour when tested. However, WebKit has a problem with this. If I set the value of a textarea in ecmascript to "A\r\ntext\r\nfield" and fetch the value back out, the \r\n sequences are still there. Only if I change the value of the textarea by hand do the sequences get translated. After examining the code, I'm guessing this is because HTMLTextAreaElementImpl caches the value of the textarea and simply returns that cached value if the NSTextView widget hasn't been touched. And since the translation happens down in KWQTextArea, the returned value still contains the \r\n. As you can imagine, this causes quite a few problems when trying to handle the selection, since the selection can stay the same and the text change underneath it, since the selection isn't cached in HTMLTextAreaElementImpl and will always be fetched from the KWQTextArea (at least, as of this writing - I see no reason to try to cache it), so the selection will always be given assuming the translation is in place (which is another issue - I have to modify the real selection to return the perceived selection, since the NSTextView's text still contains the \r\n sequences, KWQTextArea simply translates when returning the text value) Another issue related to this is KWQTextArea has accessors for the cursor position (but not the selection - odd), which do not take into account the translation. I'm not entirely sure how to test this, since they're only used when updating the widget, and I haven't looked at this enough to figure out how to actually trigger that, but I imagine it could cause the cursor position to change based on the \r \n translation. But this is actually fixable once the above issue is dealt with. Anyway, I'm looking for a solution to the problem outlined above. Should we translate the text when setting it from Javascript? But that makes HTMLTextAreaElementImpl acquire behaviour that was hidden down in KWQTextArea, behaviour that I don't if it should belong in HTMLTextAreaElementImpl. Should we stop caching the text value in HTMLTextAreaElementImpl? I'm not sure why it is cached, AFAIK it's not something that's being accessed over and over, the only real benefit to caching is to avoid translating the NSString to a QString each time it's accessed. Should we invalidate the cached value when setting a new value in code? I'm not sure how to do that, because I'm not sure where the set value is pushed down to the KWQTextArea. Does anybody who has more experience with this code than a single day have any comments or suggestions for this problem? -- Kevin Ballard kevin(a)sb.org http://www.tildesoft.com http://kevin.sb.org

2 10

Using cvsps-2.1 with WebKit
by ddkilzer＠kilzer.net 21 Jun '05

21 Jun '05

If anyone is interested in using cvsps-2.1 to pull patchsets (or patchset info) from CVS for WebKit (very handy for backing out entire commits using "patch --reverse"), I created a couple of patches to fix issues I found when running cvsps against anoncvs.opensource.apple.com. http://www.cobite.com/cvsps/ The attached patches do the following: cvsps-2.1-alloc-logbuff-dynamically.diff - Dynamically allocate a char* buffer for log entries. Previously, at least one of the log entries in WebCore was being truncated because it was longer than 32K. cvsps-2.1-ignore-TRUNK-branch.diff - Ignore the TRUNK pseudo-branch when reading in revisions for a file. If you're using fink, the cvsps.info and cvsps.patch files may be downloaded from here: http://sourceforge.net/tracker/index.php?func=detail&aid=1098684&group_id=1… The patches have also been posted to the Debian Bug Tracking System and sent to the author. Dave

1 0

Distribute to 10.3?
by Robert Fischer 21 Jun '05

21 Jun '05

Hi there, at the moment I am writing an application which heavily depends on DOM. To make it run on 10.3, too, my idea is to distribute WebKit frameworks together with my app. Is this permitted? I did not found any license agreements on webkit.darwin.org. Besides this legal issue: has anybody got WebKit compiled on 10.4 (with MACOSX_DEPLOYMENT_TARGET 10.3) to run on 10.3? My test app complains about missing references, e.g. "WebKit undefined reference to _kCGImageSourceShouldPreferRGB32". Thanks in advance, Robert -- --- - .-. -- -- --- / \ ---- tin:b Software .-. / \ --- .-. __o .-. (i) / \ / \ / \ _`\<,_ / \ Robert Fischer / \ / \ / \ (*)/ (*) / `--------------- / `---' `-' `-----------'

4 8

RE: [webkit-dev] Greetings from the Series 60 mobile browser team at Nokia
by guido.grassel＠nokia.com 21 Jun '05

21 Jun '05

I agree, adding SVG support is of interest. SVG is of interest to mobile devices. SVG can be of help to improve the device independence of Web content and give a richer experience to users who are browsing these pages. You might have noticed already that Nokia Series 60 is taking some first steps for SVG support http://svg.org/story/2004/10/21/113212/25. Nokia Research Center also participates in the SVG and the CDF working groups of the W3C. ----- I have two questions about the SVG project: on webkit.opendarwin.org: - How do people see the level of SVG support in KSVG2 ? In the mobile context SVG-Tiny 1.1 is the relevant SVG profile. - How feasible do people see switching the DOM inside WebCore? - How to ensure that adding support for new markups, such as SVG, MathML, etc., will not bloat WebCore's architecture? Cheers - Guido -----Original Message----- From: ext Robin Berjon [mailto:robin.berjon@expway.fr] Sent: Tuesday, June 14, 2005 4:31 AM To: Geisler Roland (Nokia-TP-MSW/Boston) Cc: webkit-dev(a)opendarwin.org Subject: Re: [webkit-dev] Greetings from the Series 60 mobile browser team at Nokia Hi Roland, roland.geisler(a)nokia.com wrote: > I'm heading marketing and strategy at Nokia for Series 60's new > mobile browser that will be built upon WebCore/KHTML and > JavaScriptCore/KJS. I am writing you this email to thank you for > having built the Konqueror and Safari browser with the two components > WebCore/KHTML and JavaScriptCore/KJS. This is great news! As a developer for both OSX and S60 platforms, I look forward to the result. I am curious on one point (at least) however: the new WebKit website mentions SVG as one of the projects to integrate based on KSVG2, and compound documents are a really hot topic for us content and service developers these days. So if the KSVG2 merge into KHTML happens, would you be interested in including that on S60 platforms as well? I would assume you might wish to subset it in which case I wonder what your plans may be in that regard or anything you might be looking for. I'd certainly love to see that happen, and would help if possible. Thanks for any information, -- Robin Berjon Senior Research Scientist Expway, http://expway.com/

3 2

RE: [webkit-dev] Widget / Drawing API thoughts
by David.Carson＠nokia.com 21 Jun '05

21 Jun '05

Hi Maciej, > On Jun 20, 2005, at 3:35 PM, Maciej Stachowiak wrote: > > [snip] > > > I was thinking of maybe a tree structure like this > > > > WebCore > > khtml > > bridge (stuff from kwq that's for bridging to a higher level > > API library, not about replacing Qt/KDE) > > kwq (strictly Qt/KDE replacements) > > headers > > common > > macosx > > > > Then gtk could be added as a peer directory to macosx (and > > hopefully in the future xwwindows, symbian, win32, and so forth). [snip] > I think this sounds good. Though one little nitpick I have is that I > think it's better to name the directories after toolkits rather than > platforms. (i.e. cocoa rather than macosx) I think it's a bit > clearer, as multiple ports could run on OS X. (Of course, like > wxWidgets. ;-) [snip] For us, we have mostly Symbian dependancies, and very few Series 60 dependancies. So something like: kwq (strictly Qt/KDE replacements) headers common macosx symbian series60 would be better for us. Presently, the series60 directory would be empty. But if the form controls are moved to kwq, and we need some series60 UI widgets, we would put the code in there. > > Any thoughts from Nokia folks on how this would affect the Gtk+ or > > symbian ports? This directory structure looks fine to us at Nokia. We had actaully already seperated the bridge code some time ago into a different directory. Cheers David Carson

1 0

Building WebKit CVS with XCode 2.1
by Clever Monkey 20 Jun '05

20 Jun '05

I ran into a few problems building CVS with XCode 2.1. The first was a "well-known" (to Google, anyway) warning with xcodebuild needing it's option changed to "-configuration". I hacked Makefile.am to fix that. Of more interest is that JavaScriptCore would immediately fail when it hit source that includes some headers from JavaScriptCore/bindings/ jni. Specifically, those headers that reference <JavaVM/jni.h>. This would in turn cause a long list of errors related to important Java defines like jstring and the like. My solution was to softlink the contents of /Library/Java/Home/ include to some valid include path. I chose WebKitBuild/Deployment/ include/JavaVM. I'm hoping to confirm whether or not there is some problem with my devtools setup, or if this is a known problem. Thanks. -- John

3 4

minor tool improvement ideas (sharing my personal list)
by Darin Adler 20 Jun '05

20 Jun '05

I keep a little file on my machine with ideas for tool improvements. I haven't put any of these ideas into bugzilla yet, but I wanted to share them with the rest of you in case someone wants to do some of these: update script that opens all files with merge conflicts in an editor run-webkit-tests option that gives backtraces for failed tests run-webkit-tests option that puts you in gdb and re-runs any test that crashed enhance cvs-apply and cvs-unapply to handle 3-way merges when patches are old make cvs-apply/unapply smarter about applying patch one level too high/low teach cvs-apply/unapply how to handle ChangeLog merging so they don't always think there's a conflict teach cvs-apply to update the date on a ChangeLog entry it's merging cvs-fix-patch: a script we have internally, make one for WebKitTools/Scripts cvs-clean: a script we have internally, move it to WebKitTools/ Scripts change to respect .cvsignore as Maciej suggested turns out it's really hard to respect .cvsignore by default, since there are so many different sources of things to ignore (defaults, server-side, per-directory .cvsignore, home directory .cvsignore) It would even be helpful to write bugzilla bugs about the best ideas from this list. -- Darin

2 2

Debugging in Xcode using a custom executable
by Mitz Pettel 20 Jun '05

20 Jun '05

Is there a way to debug WebKit using a custom executable in Xcode? I opened a new project, created a custom executable with / Applications/Safari.app as the executable path and with the environment variable DYLD_FRAMEWORK_PATH set to the build destination of WebKit. Source-level debugging seems to work only for the objective-C parts, though. The C++ parts show as "??" in the call stack and of course I don't get their source code. Any suggestions? -- Mitz Pettel

2 2

upcoming renaming, your chance for feedback
by Darin Adler 20 Jun '05

20 Jun '05

I am planning on renaming the following classes, source files, and methods in WebKit: WebBaseResourceHandleDelegate -> WebLoader WebMainResourceClient -> WebMainResourceLoader WebSubresourceClient -> WebSubresourceLoader WebNetscapePluginConnectionDelegate -> WebNetscapePlugInStreamLoader subresourceClients -> subresourceLoaders mainClient -> mainResourceLoader plugInStreamClients -> plugInStreamLoaders _addSubresourceClient -> _addSubresourceLoader _removeSubresourceClient -> _removeSubresourceLoader _addPlugInStreamClient -> _addPlugInStreamLoader _removePlugInStreamClient -> _removePlugInStreamLoader Let me know if you have any thoughts on the new names before I do this. I'll wait at least a couple of days before I do it (and maybe even a few weeks). -- Darin

1 0

Stuck... again (Conserative GC)
by Justin Haygood 20 Jun '05

20 Jun '05

the Win32 API simply does not allow getting the base stack address of a thread, because: 1. not stable.. Windows *WILL* and *DOES* move that base address at will. 2. Its exclusively chosen and managed by Windows itself.. no ands, buts, or ors about it. In fact, the only way to get it is via the *IoGetInitialStack(*); function, which isn't calleable by user space functions (its a kernel driver function, only defined in ntddk.h, and last time i checked, we don't want a browser running in kernel-space. What would be an alternative way to implement a conservative GC that I can use?

3 5