<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - WebKit fails to build - error: 'webrtc/rtc_base/network.h' file not found"
   href="https://bugs.webkit.org/show_bug.cgi?id=235459#c4">Comment # 4</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - WebKit fails to build - error: 'webrtc/rtc_base/network.h' file not found"
   href="https://bugs.webkit.org/show_bug.cgi?id=235459">bug 235459</a>
              from <span class="vcard"><a class="email" href="mailto:msaboff@apple.com" title="Michael Saboff <msaboff@apple.com>"> <span class="fn">Michael Saboff</span></a>
</span></b>
        <pre>(In reply to Mark Lam from <a href="show_bug.cgi?id=235459#c3">comment #3</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=449705&action=diff" name="attach_449705" title="Patch">attachment 449705</a> <a href="attachment.cgi?id=449705&action=edit" title="Patch">[details]</a></span>
> Patch

> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=449705&action=review">https://bugs.webkit.org/attachment.cgi?id=449705&action=review</a>

> I'm not super familiar with the plumbing of all the settings variables, but
> this patch LGTM.

> > Source/ThirdParty/libwebrtc/Scripts/create-symlink-to-altroot.sh:27
> > +    RELATIVE_PATH_FROM_SYMLINK_TO_ROOT=$(echo "${PUBLIC_FOLDER_PREFIX}" | sed -E -e "s/\/[a-zA-Z0-9_]+/..\//g" -e "s/\/$//")

> Why is this "s/\/$//" needed?</span >

To eliminate any trailing '/'.

<span class="quote">> > Source/ThirdParty/libwebrtc/Scripts/create-symlink-to-altroot.sh:28
> > +    SYMLINK_VALUE="${RELATIVE_PATH_FROM_SYMLINK_TO_ROOT}${INSTALL_FOLDER_PREFIX}/${TARGET}"

> nit: call this SYMLINK_TARGET instead?</span >

This follows some the name of other similar scripts.

<span class="quote">> > Source/ThirdParty/libwebrtc/Scripts/create-symlink-to-altroot.sh:52
> > +        if [[ ! -d ${SYSTEM_PUBLIC_HEADER_PREFIX} ]]; then
> > +            mkdir -p ${SYSTEM_PUBLIC_HEADER_PREFIX}
> > +        fi

> Can't you do this just once outside of the for loop?  The only difference is
> that moving this out would create this directory even if HEADER_FOLDER_LIST
> is empty.  But we know it'll never be empty, right?

> > Source/ThirdParty/libwebrtc/Scripts/create-symlink-to-altroot.sh:64
> > +        if [[ ! -d ${SYSTEM_PUBLIC_LIBRARY_PREFIX} ]]; then
> > +            mkdir -p ${SYSTEM_PUBLIC_LIBRARY_PREFIX}
> > +        fi

> Ditto.  Do this outside the for loop?</span >

I moved both of these to above the loop.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>