<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Grid may be empty in certain scenarios"
   href="https://bugs.webkit.org/show_bug.cgi?id=234578#c6">Comment # 6</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Grid may be empty in certain scenarios"
   href="https://bugs.webkit.org/show_bug.cgi?id=234578">bug 234578</a>
              from <span class="vcard"><a class="email" href="mailto:svillar@igalia.com" title="Sergio Villar Senin <svillar@igalia.com>"> <span class="fn">Sergio Villar Senin</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=449432&action=diff" name="attach_449432" title="patch">attachment 449432</a> <a href="attachment.cgi?id=449432&action=edit" title="patch">[details]</a></span>
patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=449432&action=review">https://bugs.webkit.org/attachment.cgi?id=449432&action=review</a>

There is one test failing. Check it out.

<span class="quote">> Source/WebCore/rendering/RenderGrid.cpp:178
>  </span >

Perhaps add a comment here explaining that this must be run after calling updateLogicalWidth() otherwise the shouldSkipChild() won't properly work. It'd be better to have an ASSERT for it, but I don't think it'd be easy to come up with any.

<span class="quote">> Source/WebCore/rendering/RenderGrid.cpp:179
> +void RenderGrid::computeAspectRatioDependantAndBaselineItems(Vector<RenderBox*> &aspectRatioBlockSizeDependentGridItems)</span >

Nit: the & should be placed right next to the type not the variable name

<span class="quote">> Source/WebCore/rendering/RenderGrid.h:194
> +    void computeAspectRatioDependantAndBaselineItems(Vector<RenderBox*> &aspectRatioBlockSizeDependentGridItems);</span >

Nit: the & should be right next to the type.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>