<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Dead code in LinkIconCollector.cpp"
href="https://bugs.webkit.org/show_bug.cgi?id=234234#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Dead code in LinkIconCollector.cpp"
href="https://bugs.webkit.org/show_bug.cgi?id=234234">bug 234234</a>
from <span class="vcard"><a class="email" href="mailto:karl+webkit@la-grange.net" title="karl <karl+webkit@la-grange.net>"> <span class="fn">karl</span></a>
</span></b>
<pre>Alex,
<span class="quote">> How did you find this?</span >
I was in the process of reading the code because I had just opened
<a href="https://bugzilla.mozilla.org/show_bug.cgi?id=1745680">https://bugzilla.mozilla.org/show_bug.cgi?id=1745680</a>
And I was trying to understand how WebKit, Blink and Gecko were processing html link for icons. So I just casually reading the code when I stumbled upon this dead code.
<span class="quote">> can it be tested?</span >
It can be probably tested, being my first ever patch to WebKit. I don't see any tests for compareIcons()
The code was added 5+ years ago without tests.
<a href="https://github.com/WebKit/WebKit/commit/0148de572687b1981331e70d1135408ae8cac4f2#diff-f6e9e7480dfa766ab4c1f0b36526f8faf97018240ba256b2217236e479c43919R50-R56">https://github.com/WebKit/WebKit/commit/0148de572687b1981331e70d1135408ae8cac4f2#diff-f6e9e7480dfa766ab4c1f0b36526f8faf97018240ba256b2217236e479c43919R50-R56</a>
If you have recommendations on where these tests should go, I can try.
<span class="quote">> Also, we don't need to redo formatting in the change log with this.</span >
Yes, my VSCode instance has probably reformatted the Changelog. I need to fix this. Is there a URL to a recommended vscode setup for the WebKit project.
Thanks.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>