<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GPUP] Create WebGL context with task id token"
href="https://bugs.webkit.org/show_bug.cgi?id=234138">bug 234138</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>darin@apple.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GPUP] Create WebGL context with task id token"
href="https://bugs.webkit.org/show_bug.cgi?id=234138#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GPUP] Create WebGL context with task id token"
href="https://bugs.webkit.org/show_bug.cgi?id=234138">bug 234138</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=446781&action=diff" name="attach_446781" title="Patch">attachment 446781</a> <a href="attachment.cgi?id=446781&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=446781&action=review">https://bugs.webkit.org/attachment.cgi?id=446781&action=review</a>
A few coding style tweaks
<span class="quote">> Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h:367
> + GraphicsContextGLANGLE(GraphicsContextGLAttributes, ProcessIdentity&);</span >
Could this be "const ProcessIdentity&"? It’s a bit unusual to pass a non-constant lvalue reference and I don’t see why we need to.
<span class="quote">> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:204
> +GraphicsContextGLCocoa::GraphicsContextGLCocoa(GraphicsContextGLAttributes &&creationAttributes, ProcessIdentity &&resourceOwner)</span >
Why moving these "&&"? WebKit coding style calls for the way we had it already.
<span class="quote">> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:336
> + const char *displayExtensions = EGL_QueryString(m_displayObj, EGL_EXTENSIONS);</span >
WebKit coding style calls for "const char*" or "auto".
<span class="quote">> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:340
> + task_id_token_t ownerTaskIdToken = resourceOwner.taskIdToken();</span >
Seems like we don’t need this local variable.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>