<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
          <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Correctly support fragment-only URLs in CSS images"
   href="https://bugs.webkit.org/show_bug.cgi?id=229917">bug 229917</a>
          <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Attachment #444457 Flags</td>
           <td>review?
           </td>
           <td>review+
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Correctly support fragment-only URLs in CSS images"
   href="https://bugs.webkit.org/show_bug.cgi?id=229917#c26">Comment # 26</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Correctly support fragment-only URLs in CSS images"
   href="https://bugs.webkit.org/show_bug.cgi?id=229917">bug 229917</a>
              from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=444457&action=diff" name="attach_444457" title="Patch">attachment 444457</a> <a href="attachment.cgi?id=444457&action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=444457&action=review">https://bugs.webkit.org/attachment.cgi?id=444457&action=review</a>

<span class="quote">> Source/WebCore/css/CSSImageValue.cpp:87
> +    if (CSSValue::isCSSLocalURL(m_location.resolvedURL.string()))</span >

This can just be:

   if (isCSSLocalURL(...

Since CSSImageValue derives from CSSValue.

<span class="quote">> Source/WebCore/css/CSSImageValue.cpp:88
> +        return URL(URL(), m_location.resolvedURL.string());</span >

This can just be:

    return m_location.resolvedURL;

No need to re-create the URL from a string.

<span class="quote">> Source/WebCore/css/CSSValue.h:157
> +    // Empty URLs and fragment-only URLs should not be resolved relative to the base
> +    // URL.</span >

Let’s not break the word URL onto a separate line.

<span class="quote">> Source/WebCore/css/CSSValue.h:158
> +    static bool isCSSLocalURL(const String& url)</span >

I might name this argument "relativeURL". I suggest this take a StringView, not a const String&.

If it was me, I would also move this function body out of the class definition.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>