<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] Implement Temporal.Instant"
href="https://bugs.webkit.org/show_bug.cgi?id=229826#c36">Comment # 36</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] Implement Temporal.Instant"
href="https://bugs.webkit.org/show_bug.cgi?id=229826">bug 229826</a>
from <span class="vcard"><a class="email" href="mailto:philip.chimento@gmail.com" title="Philip Chimento <philip.chimento@gmail.com>"> <span class="fn">Philip Chimento</span></a>
</span></b>
<pre>(In reply to Yusuke Suzuki from <a href="show_bug.cgi?id=229826#c34">comment #34</a>)
<span class="quote">> > Source/JavaScriptCore/runtime/TemporalInstant.cpp:233
> > + int64_t microseconds = JSBigInt::toBigInt64(bigint);
>
> It is not handling negative Int128 ranges (if JSBigInt's 2 digits are larger
> than INT128_MAX, then if it is signed, it is not within Int128 range).
> Can you fix it and add test for this?</span >
I guess you mean INT64_MAX here?
I've fixed these cases, added tests, and added the assertion.
Additionally I adjusted the test with the BigInt('9'.repeat(2147483648)) case, because I suspect that constructing that string was what was making the jsc-armv7 tests fail. (Anyway, the test was not actually testing what we thought it would, because BigInts that large are not allowed.)
Hopefully ready to land this time.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>