<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][WPE] UserInteractive threads are not Real-time in Linux"
href="https://bugs.webkit.org/show_bug.cgi?id=220115#c54">Comment # 54</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][WPE] UserInteractive threads are not Real-time in Linux"
href="https://bugs.webkit.org/show_bug.cgi?id=220115">bug 220115</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@gnome.org" title="Michael Catanzaro <mcatanzaro@gnome.org>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>(In reply to Carlos Garcia Campos from <a href="show_bug.cgi?id=220115#c52">comment #52</a>)
<span class="quote">> This is always called in the main thread.</span >
That doesn't mean it's OK to use.
Anyway, we have <a class="bz_bug_link
bz_status_NEW "
title="NEW - Do not use strerror()"
href="show_bug.cgi?id=231913">bug #231913</a> for this. I suppose I can always just update the patch there if this one lands first.
<span class="quote">> >> Source/WTF/wtf/linux/RealTimeThreads.cpp:173
> >> + RELEASE_ASSERT_NOT_REACHED();
> >
> > Woah! We assert if an rtkit properly is invalid. That's not programmer error in WebKit, and it's not enough reason to crash either. Instead, call g_set_error_literal() with some canned message and return -1.
>
> That would mean it's not the rtkit service we expect to talk to, we always
> expect the properties to be either a int64 or int32.</span >
That's not a WebKit programmer error, so assert is definitely inappropriate.
Crashing seems inappropriate too. What's wrong with returning a normal error.
<span class="quote">> RunLoop::Timer is thread safe. it's a *main loop* timer, so the callback is
> always called in the main thread. And m_realTimeKitProxy is also called in
> the main thread only, because promoteThreadToRealTime() is always called in
> the main thread.</span >
OK, can you add some ASSERT(isMainThread()) then? That would make the safety easier to see.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>